WIP#1
Conversation
| import emberSourceChannelURL from "ember-source-channel-url"; | ||
| // import { embroiderOptimized, embroiderSafe } from "@embroider/test-setup"; | ||
| // import emberSourceChannelURL from "ember-source-channel-url"; | ||
| import { fileHandlers } from "../dist/index.js"; |
There was a problem hiding this comment.
| import { fileHandlers } from "../dist/index.js"; | |
| import { fileOperations } from "../dist/index.js"; |
Maybe? Naming still feels a bit weird.
There was a problem hiding this comment.
As much as fileOperations sounds more accurate, fileHandlers gives a bit more "familiar" feeling.
🤷
| const restoreFiles = await backUpFiles(cwd, [ | ||
| // "package.json", | ||
| lockfile, | ||
| ...Object.keys(scenario.files), |
There was a problem hiding this comment.
Make sure all files are backed up first.
There was a problem hiding this comment.
must also include package.json when config.packageJson is present
| /** | ||
| * Apply a scenario's files. | ||
| */ | ||
| export function applyScenarioFiles( |
There was a problem hiding this comment.
This is the main logic regarding files.
| @@ -0,0 +1,22 @@ | |||
| import { flattenObject } from "flatten-anything"; | |||
There was a problem hiding this comment.
An operation that allows you to modify the contents of a JSON file more easily would also be useful I think:
files: {
'package.json': fileOperations.modifyJson((pkg) => {
delete pkg.foo.bar;
return pkg;
}),
},Or something similar.
| const restoreFiles = await backUpFiles(cwd, [ | ||
| // "package.json", | ||
| lockfile, | ||
| ...Object.keys(scenario.files), |
There was a problem hiding this comment.
must also include package.json when config.packageJson is present
| @@ -0,0 +1,22 @@ | |||
| import { flattenObject } from "flatten-anything"; | |||
| import emberSourceChannelURL from "ember-source-channel-url"; | ||
| // import { embroiderOptimized, embroiderSafe } from "@embroider/test-setup"; | ||
| // import emberSourceChannelURL from "ember-source-channel-url"; | ||
| import { fileHandlers } from "../dist/index.js"; |
There was a problem hiding this comment.
As much as fileOperations sounds more accurate, fileHandlers gives a bit more "familiar" feeling.
🤷
I'm def planning on finishing this properly, but I probably need a bit more time. |
2 participants
No description provided.