Skip to content

Add bevy_mod_config to Assets/Configuration#591

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
SOF3:bevy_mod_config
Apr 14, 2026
Merged

Add bevy_mod_config to Assets/Configuration#591
alice-i-cecile merged 1 commit intobevyengine:mainfrom
SOF3:bevy_mod_config

Conversation

@SOF3
Copy link
Copy Markdown
Contributor

@SOF3 SOF3 commented Apr 12, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 12, 2026 16:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new asset metadata entry for the bevy_mod_config crate under the Assets/Configuration category, consistent with the existing asset listing TOML schema used elsewhere in Assets/.

Changes:

  • Added Assets/Configuration/bevy_mod_config.toml with name/description/link/crate metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a potential user, I have a hard time understanding what that means... concretely? Why is it particularly useful for editor UI? What's the relation to persistence? Why would I want a modular configuration framework?

You're welcome to describe your crate however you like: that feedback is merely advisory.

In terms of categorization... maybe something like "settings" would be clearer?

@SOF3
Copy link
Copy Markdown
Contributor Author

SOF3 commented Apr 14, 2026

not sure what is the best way to put it. the idea is that the game developer writes the settings data model, and other plugin providers (those providing a Manager impl) would provide plugins such as persistence and editor UI (and maybe other things you can do with the same data model).
explaining all these would seem too long for a oneline description in the bevy-assets format. what would you suggest about that?

@alice-i-cecile
Copy link
Copy Markdown
Member

My partner says this makes sense to her 😅 I'll just merge this for now; feel free to revise if you have better wording in the future.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 14, 2026
Merged via the queue into bevyengine:main with commit cc2a896 Apr 14, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants