feat: forward ACP prompt content to Muse - #3
Draft
obviyus wants to merge 2 commits into
Draft
Conversation
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The adapter currently keeps only ACP text blocks. Images, resource links, audio, and embedded resources are silently discarded. A prompt can therefore appear to succeed while Muse never receives the user's attachment.
Fix
--imageflag.0700directory and0600file permissions.The adapter does not duplicate Muse's image-size policy. Muse 1.0.1 rejects oversized files before model execution with its exact 20 MiB limit.
Live proof
CATfrom the attached PNG.CATimage as PNG, JPEG, GIF, and WebP and returned4.image file is too large (... > 20971520 bytes).missing prompt; the adapter now reports the required text before spawn.Verification
npm run checknpm run buildnpm run test:run— 110 passed, 2 live-only skippedDependency
This draft includes the test-only commit from #2 so the Muse 1.0 suite is green. Merge #2 first; GitHub will then reduce this PR to the content implementation.