This repository was archived by the owner on Mar 14, 2024. It is now read-only.
Fixes required for Windows functionality#39
Open
sdonchez wants to merge 1 commit intobeyondcode:masterfrom
Open
Fixes required for Windows functionality#39sdonchez wants to merge 1 commit intobeyondcode:masterfrom
sdonchez wants to merge 1 commit intobeyondcode:masterfrom
Conversation
Windows can't handle TTY, so this checks the OS before setting the flag. Allows the user to configure the timeout, because 60 seconds is annoying if you're setting a lot of variables. Also allows parameters to be passed into the editor call, as Visual Studio Code, for example, requires a -w flag to block the terminal until the user is done editing. Co-Authored-By: andrewkurzweil <26608741+andrewkurzweil@users.noreply.github.com>
sdonchez
commented
Jan 10, 2021
| config('credentials.timeout')); | ||
|
|
||
| $process->setTty(true); | ||
| if (!(stripos(PHP_OS, 'WIN') === 0 || PHP_OS_FAMILY === "Windows")) |
Author
|
@mpociot Is there anything I can do to help get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows can't handle TTY, so this checks the OS before setting the flag. Allows the user to configure the timeout, because 60 seconds is annoying if you're setting a lot of variables. Also allows parameters to be passed into the editor call, as Visual Studio Code, for example, requires a -w flag to block the terminal until the user is done editing.
This resolves issue #37 and #15. It coincidentally duplicates the effort in #38, since it's impossible to test without that fix.
Kudos to @b0ric for the tty check conditions in #15.
Co-Authored-By: andrewkurzweil 26608741+andrewkurzweil@users.noreply.github.com