Repository navigation
refactor(arca-gui): derive view font sizes from the body text size - #69
Merged
devin-ai-integration[bot] merged 2 commits intoOct 18, 2026
Merged
Conversation
Browser rows, column headers, dialogs and settings rows drew text with literal sizes, so the Text size setting never reached them. The new theme::text_size/text_font/mono_font helpers offset the installed Body size; at the default 13 pt every size equals the old literal. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…-size-fonts Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # arca-gui/src/ui/dialogs.rs # arca-gui/src/ui/pathbar.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme::installsetsTextStyle::Bodyfromsettings.text_size, but about 30 text sites inarca-gui/src/ui/used fixed sizes such asFontId::proportional(14.0)or.size(12.0). That covered browser row names, column headers and cells, peek cards, dialogs, settings rows, the status bar notice and key caps. Because of that, the Text size setting never changed them.New helpers in
theme.rstake the installed Body size and add an offset to it:Each literal now uses one of these with
delta = literal - 13(13 isTEXT_DEFAULT), e.g.FontId::proportional(14.0)→text_font(ui.style(), 1.0). At the default size every font comes out the same as before, so the default look doesn't change.What stays fixed on purpose: Phosphor icon glyph sizes (
icon_font(..)/icon_text(..).size(..)), the stepper's −/+ signs, and the test fixtures inhighlight.rs. They sit inside fixed geometry (24/30 px rows, a 26 px text offset after the row glyph, fixed button sizes). Scaling them would mean reworking that layout, which this PR doesn't do.Tests: added
view_text_follows_the_text_size_setting(theme.rs). It runsinstallat the default size and at 18 pt for both themes and checks the derived sizes.cargo clippy -p arca-gui --all-targets -D warningsandcargo test -p arca-guipass. I also ran it by hand attext_size = 20: 21 px row names still fit in the Compact 24 px rows.Link to Devin session: https://app.devin.ai/sessions/0f38f47b919e4d97a58d909cf30be015
Open in Devin Desktop: https://app.devin.ai/desktop/session/0f38f47b919e4d97a58d909cf30be015?variant=devin
Requested by: @Villoh