Repository navigation
refactor(arca-gui): spell keystroke glyphs and status separators as escapes - #73
Merged
devin-ai-integration[bot] merged 2 commits intoOct 18, 2026
Merged
Conversation
…scapes
AGENTS.md keeps source strings ASCII-only; the keystroke glyphs and the status-line middle dots were the remaining literal spellings, while the rest of arca-gui already uses \u{..} escapes. The produced strings are byte-identical.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…i-glyph-escapes Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # arca-gui/src/ui/dialogs.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md says source strings stay ASCII-only.
keystroke()inui/dialogs.rsused literal glyphs (⌘ ⌥ ⇧ ← → ↑ ↓), andAppController::summary()incontroller/mod.rsused literal·separators. Everywhere else, arca-gui already writes these as escapes (e.g."{l} \u{b7} {name}"in the same controller file), so this PR switches these spots to the same style:The strings produced are byte-identical, so rendering doesn't change. The existing
keystrokeassertions inui/tests.rs("⌘⇧C","Alt+←") still pass unchanged.Checks:
cargo fmt --all -- --check,cargo clippy -p arca-gui --all-targets -- -D warnings,cargo test -p arca-gui(253 passed).Link to Devin session: https://app.devin.ai/sessions/79991db7f9254d59bf5d28fc5addb929
Open in Devin Desktop: https://app.devin.ai/desktop/session/79991db7f9254d59bf5d28fc5addb929?variant=devin
Requested by: @Villoh