Repository navigation
search: clip long match lines at rg's column; no client re-matches (D3) - #598
Closed
jaredLunde wants to merge 43 commits into
Closed
jaredLunde wants to merge 43 commits into
jaredLunde wants to merge 43 commits into
Conversation
Hegel generates operation sequences (files, search, exec, and changes made behind the client's back); each runs in lockstep through every registered driver on its own root, and the answers are compared with each other and, on local backends, with std::fs. Findings D1..D5 are scenarios in differential-found.json, xfail for the clients that fail them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…lit at CR, VT, FF, U+2028) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git
… even on SIGKILL; differential tests run only in the clients job Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…, not a rejected pattern Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
… jared/fix-d2-search-bad-git
… jared/fix-d1-py-stderr-line
… jared/fix-d3-clip-rg-column
…o jared/fix-d2-search-bad-git
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git
…o jared/fix-d3-clip-rg-column
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d2-search-bad-git # Conflicts: # sdk/conformance/FILES-OVER-EXEC.md
…rches the line again Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d3-clip-rg-column
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…ferential tolerance Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…gs clip at the head Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
… jared/fix-d2-search-bad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md
…o jared/fix-d3-clip-rg-column
…rches the line again (docs, merge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
… built on the Rust client) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…rop exec.exact from the comparison Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…er lead out of the root Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…ad-git # Conflicts: # sdk/conformance/FILES-OVER-EXEC.md
… jared/fix-d2-search-bad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md # sdk/conformance/scenarios/differential-found.json
…o jared/fix-d3-clip-rg-column # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64
…o jared/fix-d3-clip-rg-column
…ad-git # Conflicts: # crates/sandbox-conformance/ARCHITECTURE.md # crates/sandbox-conformance/tests/differential/oracle.rs # sdk/conformance/scenarios/differential-found.json
…o jared/fix-d3-clip-rg-column
jaredLunde
enabled auto-merge
October 27, 2026 20:47
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 27, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes D3. The TypeScript client re-matched long lines with a JavaScript RegExp, so Rust-syntax patterns (
(?i),(?P<x>..)) failed. No client re-matches now:rg --columnreports the byte column of the first match, and every client turns it into a character offset the same way (UTF-8 encoding of the decoded line, CRs not counted; a column inside a character means no column).Spec decisions (Clipping, Parsing, Engines differ):
start = max(0, cs - 250); start 0 is the head clip; a window past the end moves back to the last 500 characters. Previously it used the match width.Removes the D3 xfails and tolerance. Matrix: all search scenarios pass on local/alpine/debian-runas/readonly/tinydisk for rust, ts, python, python-async. The sandbox-mcp driver fails only the D5 scenario (next fix). Differential: 6/6 with the four client drivers (the mcp driver diverges on a plain mkdir in the differential, unrelated to this change).
Stacked on #594 (D2) and carries #590; retarget once they land.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HJRTKuPpNNqCLEdyUwZj64