Skip to content

fix: validate turbopuffer_base_url with outbound URL policy #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigint merged 1 commit into from
May 22, 2026
+2 −2
Merged

fix: validate turbopuffer_base_url with outbound URL policy #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/bigrag/services/runtime_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def validate_setting_value(key: str, value: Any) -> Any:
if value is None:
return None
coerced_str = str(value)
if key in {"storage_s3_endpoint_url", "backup_s3_endpoint_url"} and coerced_str.strip():
if key in {"storage_s3_endpoint_url", "backup_s3_endpoint_url", "turbopuffer_base_url"} and coerced_str.strip():
from bigrag.services.url_security import UnsafeOutboundUrlError, normalize_url_root

try:
Expand Down
2 changes: 1 addition & 1 deletion website/content/docs/api-reference/instance-settings.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Deployment-managed security keys use the same endpoint when you intentionally au

Security hardening settings include `allow_public_bind_in_prod`. Ingestion settings include raw vector API request caps (`max_vector_upsert_count`, `max_vector_delete_count`, `max_vector_text_chars`, `max_vector_metadata_bytes`). Turbopuffer settings include `turbopuffer_api_key`, `turbopuffer_base_url`, `turbopuffer_region`, and `turbopuffer_namespace_prefix`. UI-visible settings can be changed from the admin UI. Registry keys that are not rendered in the UI remain available through this API and the SDK admin settings resources.

Storage and Turbopuffer connection changes are validated before they are saved and apply to the running API.
Storage and Turbopuffer connection changes are validated before they are saved and apply to the running API. Custom `turbopuffer_base_url` values must be normalized HTTPS roots that pass outbound URL safety checks.

## Test Settings

Expand Down
Loading