improve hx-live perf by skipping no change updates#3891
Merged
Conversation
1cg
reviewed
Jul 13, 2026
| document.addEventListener('input', () => { | ||
| clearTimeout(inputDebounceId); | ||
| inputDebounceId = setTimeout(schedule, INPUT_DEBOUNCE_MS); | ||
| }, true); |
Contributor
There was a problem hiding this comment.
should this listener be captured and removed in deactivate() like the recomputeBound listener is?
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can improve hx-live performance so we can support maybe 1000 live bindings on a page by guarding writes that don't change anything so it avoids wasted time updating the dom with no changes. This gives a 2-3x speed increase
Also added a possible 100ms debounce for input events so typing into an input does not overload the live tasks at the cost of slowing down the updates from typing. change and dom mutations fire instantly still.
Corresponding issue:
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded