Fix boosted history scroll restoration#3899
Open
scriptogre wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
hx-boosted back/forward navigation loses scroll position.The browser restores scroll against the old DOM. The position clamps before htmx swaps the restored page.
Reproduce
<hx-partial>.Fix
Modern browsers:
Older browsers:
The fallback covers common back and forward cases.
Full native behavior needs more code (track scroll, update history entries, handle page lifecycle, restore after
popstate, handle repeated visits).Prior work
PR #3704 only fixed the rare
history: "reload"case and was more complex.Analysis: https://gist.github.com/scriptogre/40c5c4af3ba971b7cf9be10603a80e7c