Skip to content

fix(SDCB-18585): Remove image recognition references #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturCwiklinsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(SDCB-18585): Remove image recognition references #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions samples/testing-frameworks/appium/server-side/java/run-tests_ios.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ TEST_CASE="#mainPageTest"
## Environment variables setup
export PLATFORM_NAME=iOS
export UDID=${IOS_UDID}
export DYLD_FALLBACK_LIBRARY_PATH=${DYLD_LIBRARY_PATH}:$PWD/lib/mac/opencv:/Users/Shared/libimobiledevice-binaries-master
# Replace all spaces with escape: "\ "
export DYLD_FALLBACK_LIBRARY_PATH=${DYLD_FALLBACK_LIBRARY_PATH// /\\ }
echo "DYLD_FALLBACK_LIBRARY_PATH=${DYLD_FALLBACK_LIBRARY_PATH}"
export PLATFORM_VERSION=$(ideviceinfo --key ProductVersion)
echo "iOS Version: ${PLATFORM_VERSION}"

Expand Down
8 changes: 2 additions & 6 deletions ...eworks/appium/server-side/java/src/test/java/com/smartbear/appium/AbstractAppiumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ private static void idevicescreenshotCheck() throws Exception {
LOGGER.info("Couldn't execute command", e);
}
if (exitVal != 0) {
String errorMsg = "idevicescreenshot exited with value: %s. Please install it or add it to " +
"your path in order to use the image-recognition-opencv-library.";
throw new Exception(String.format(errorMsg, exitVal));
throw new Exception(String.format("idevicescreenshot exited with value: %s", exitVal));
}
}

Expand All @@ -97,9 +95,7 @@ private static void adbCheck() throws Exception {
LOGGER.error("Couldn't execute command", e);
}
if (exitVal != 0) {
String errorMsg = "adb exited with value: %s. Please install it or add it to your path in order to use " +
"the image-recognition-opencv-library.";
throw new Exception(String.format(errorMsg, exitVal));
throw new Exception(String.format("adb exited with value: %s", exitVal));
}
}

Expand Down
3 changes: 1 addition & 2 deletions ...meworks/appium/server-side/java/src/test/java/com/smartbear/appium/AndroidSampleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.openqa.selenium.By;
Expand All @@ -12,7 +11,7 @@
import java.time.Duration;

/**
* Testdroid Image Recognition Sample Test
* Testdroid Sample Test
*/
@ExtendWith(TestResultExtension.class)
class AndroidSampleTest extends AbstractAppiumTest {
Expand Down
3 changes: 1 addition & 2 deletions ...-frameworks/appium/server-side/java/src/test/java/com/smartbear/appium/iOSSampleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.smartbear.appium;

import io.appium.java_client.AppiumDriver;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
Expand All @@ -13,7 +12,7 @@
import java.time.Duration;

/**
* Testdroid Image Recognition Sample Test
* Testdroid Sample Test
*/
@ExtendWith(TestResultExtension.class)
class iOSSampleTest extends AbstractAppiumTest {
Expand Down