Allow Faraday to follow redirects#83
Open
wwboynton wants to merge 1 commit intobitbucket-rest-api:masterfrom
wwboynton:master
Open
Allow Faraday to follow redirects#83wwboynton wants to merge 1 commit intobitbucket-rest-api:masterfrom wwboynton:master
wwboynton wants to merge 1 commit intobitbucket-rest-api:masterfrom
wwboynton:master
Conversation
Author
|
Note, this does not solve the issue that follows that -- the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently some BitBucket endpoints will serve a 302 redirect. This was causing an error.
For example:
Following the directions from this Faraday issue, it seemed like all I needed to do was use the
FaradayMiddleware::FollowRedirectsand explicitly mount an adapter. I did that and the same code began working. You can scrutinize and change this at your leisure, butGET-ting data from (at least) that endpoint will be broken until Faraday is using redirects.