Add sigs data and scripts from asmap/asmap.sigs repo#50
Conversation
|
Concept ACK |
|
Concept ACK I have just tested the verify script and it worked for me without issue. I think I would have chosen a different folder structure. I would have done from top-level: What is still missing is moving the documentation for the sigs stuff here. That may be in the readme or in a separate attestations doc. I don't have a preference for this. |
the attestations folder is nested under each year, so we update the script paths to handle that. add a helper function to identify the year from the unix epoch. rename env vars to not mention old repo
yea, that's cleaner, done. 799175f
done in d7a7e08 I also removed the part of the CLI help text that showed an example with |
After consideration, we decided to move all attestation data close to the data itself, in this repository. This moves all attestations scripts and data (from run 1772726400) from https://github.com/asmap/asmap.sigs.
First 3 commits are direct copying of data. The last one f30ef69 adapts the
asmap-attestandasmap-verifyto the repo's structure, i.e. finding paths to write when attesting, and finding the right epochs and signature data when verifying attestations.An existing year folder for asmap data now gets an
attestationsfolder containing folders indexed by run timestamp e.g.:While I considered changing the repo's structure to have
{year}/{timestamp}/attestationsand{year}/{timestamp}/dataand think it would be cleaner, it would break the existing repo structure. i.e.:If a user wanted to get a file and its attestations in one go, they could fetch the timestamp from the file name and find the attestation folder under
attestations/{timestamp}which doesn't seem to burdensome.This adds a
year_from_epochhelper, which requires adding thedatetool to required tools, and handle it differently for GNU vs BSD/Mac (though this was an LLM-provided suggestion, and I haven't tested on Mac). Otherwise scripts functionality is unchanged.