Repository navigation
fix(data): remove 363736, a descendant of invalid 363731 - #157
Merged
Merged
Conversation
363736 is the fifth block built on 363731 in the 4 July 2015 BIP66 fork. bitcoin-data/invalid-blocks records it under prev_block_invalid since PR bitcoin-data#28 (ccb6428), together with its complete block and the four blocks between it and 363731. bitcoin-data#155 left this hash-only row in place until invalid-blocks covered descendants of invalid blocks.
Contributor
Author
|
I think the CI failure was just transient.. |
Collaborator
|
Thanks! didn't do much checking on this one, but trust it to be correct to remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
363736 is the last of the five blocks built on BIP66-invalid 363731 in the 4 July 2015 fork. bitcoin-data/invalid-blocks#28 admitted all five under
prev_block_invalid, with their complete blocks (363736's record), so this removes the hash-only row that #155 left in place until invalid-blocks covered descendants (bitcoin-data/invalid-blocks#23).Nothing else traces to an invalid block. Checked against invalid-blocks at ccb6428, no other row is a record there and no row's header or known parent descends from one; the seven rows invalid-blocks lists as reported but not established stay. Rows whose parent is unknown cannot be checked this way: the 264 hash-only rows with no recorded parent, and the six headers
ci/check-with-bitcoind.pyreports as building on unknown blocks, the same six as on master.Testing
Before and after: one row gone, the other 3,928 unchanged and in order.
ci/sanity-check.py: 3,663 headers, 1,387 block files.