feat(wallet)!: add locked balance category for unmet descriptor height-based timelocks - #538
Draft
Dmenec wants to merge 4 commits into
Draft
feat(wallet)!: add locked balance category for unmet descriptor height-based timelocks#538Dmenec wants to merge 4 commits into
Dmenec wants to merge 4 commits into
Conversation
Refactor balance() to classify pending outputs by ancestry rather than keychain type. Outputs sent to external addresses now count as trusted if their unconfirmed ancestry belongs entirely to the wallet.
Cover how balance() classifies unconfirmed outputs by ancestry: - Spending our own confirmed coin is trusted. - An input we do not own is untrusted. - Trust propagates down a chain that only spends our coins. - Paying our change keychain does not trust a foreign input. - Spending a foreign output is untrusted even next to a trusted change output. - Spending an owned-but-untrusted output stays untrusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180.
Description
Adds a
lockedbalance category for confirmed outputs that are not yet spendable because a descriptor timelock has not matured. These outputs were previously counted asconfirmed.Notes to the reviewers
Draft unti #431 and bitcoindevkit/bdk#2246 land.
This branch is stacked on #431, which in turn needs the
CanonicalViewAPI from bdk#2246 in a publishedbdk_chainrelease before it can build.Changelog notice
lockedbalance category for confirmed outputs whose descriptor timelock has not matured.Wallet::balancenow returnsWalletBalance.All Sumbissions:
Bugfixes: