feat: add frigate electrum based RPC methods - #16
Open
sdmg15 wants to merge 5 commits into
Open
Conversation
sdmg15
changed the title
server.version, blockchain.silentpayments.subscribe and blockchain.silentpayments.unsubscribe
sdmg15
force-pushed
the
master
branch
2 times, most recently
from
April 30, 2026 17:00
225fc0c to
885cd2f
Compare
sdmg15
marked this pull request as ready for review
May 1, 2026 14:32
Member
|
Thanks for the PR! Note that it needs a rebase now with the recent merges. |
evanlinjin
requested changes
May 7, 2026
… `blockchain.silentpayments.unsubscribe`
oleonardolima
left a comment
oleonardolima
left a comment
Contributor
There was a problem hiding this comment.
In https://github.com/sparrowwallet/frigate#serverfeatures it mentions the new field in server.features, is it not needed by bdk-sp ?
Contributor
|
@sdmg15 I just thought this now during the call, but you could also try adding support for these in https://github.com/bitcoindevkit/rust-electrum-client, not sure if the architecture there supports it though. |
noahjoeris
requested changes
Jul 21, 2026
noahjoeris
requested changes
Aug 3, 2026
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks for updating @sdmg15 !
I left a few more comments
Author
|
@noahjoeris Thanks for the reviews. I've applied the changes. |
noahjoeris
requested changes
Aug 10, 2026
noahjoeris
left a comment
noahjoeris
left a comment
There was a problem hiding this comment.
Thanks again for updating man. Almost there 🚀
Could you also add doc comments to the pub fields you added?
noahjoeris
self-requested a review
August 25, 2026 18:31
noahjoeris
requested changes
Aug 26, 2026
Comment on lines
+324
to
+327
| pub struct SpSubscribeResp { | ||
| pub address: String, | ||
| pub labels: Vec<u32>, | ||
| pub start_height: u32, |
Comment on lines
+332
to
+336
| pub struct TxTweak { | ||
| pub height: u32, | ||
| pub tx_hash: bitcoin::Txid, | ||
| pub tweak_key: bitcoin::secp256k1::PublicKey, | ||
| } |
Comment on lines
+722
to
+725
| // A 64 character string containing the hex of the scan private key. | ||
| pub scan_priv_key: bitcoin::secp256k1::SecretKey, | ||
|
|
||
| // A 66 character string containing the hex of the spend public key. |
Comment on lines
+121
to
+124
| pub struct SpNotification { | ||
| pub subscription: response::SpSubscribeResp, | ||
| pub progress: f32, | ||
| pub history: Vec<response::TxTweak>, |
Comment on lines
+671
to
+677
| // A 64 character string containing the hex of the scan private key. | ||
| pub scan_priv_key: bitcoin::secp256k1::SecretKey, | ||
|
|
||
| // A 66 character string containing the hex of the spend public key. | ||
| pub spend_pub_key: bitcoin::secp256k1::PublicKey, | ||
|
|
||
| // Block height or timestamp to start scanning from. Values above 500,000,000 are treated as seconds from the start of the epoch. |
|
Thanks @sdmg15 . I left some final nits. And I ran a quick manual test and it was looking good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds supports for additional RPC methods provided by Frigate electrum based RPC server.
The added methods are:
server.version: This is the first message sent to establish connection with serverblockchain.silentpayments.subscribe: This takes a spend public key and a scan private key and return outputs belonging to the them.blockchain.silentpayments.unsubscribe: This takes a spend public key and a scan private key and unsubscribe from notifications.Some context:
This is useful for the PR opened at bitcoindevkit/bdk-sp#48 which is doing integration of frigate ephemeral scanning.
Opening this PR in order to receive feedback.
Reference:
https://github.com/sparrowwallet/frigate/
Supported Frigate version 1.3.2