feat(client)!: connect over TCP and TLS - #19
Open
noahjoeris wants to merge 4 commits into
Open
Conversation
rustls 0.23 requires 1.71. This is crate-wide, so the following TLS feature is a breaking change for 1.70 toolchains.
Keep hostnames unresolved for later TLS/SNI, and give blocking/tokio clients a connect-only TCP constructor. Dropping the blocking client shuts the TCP socket down so the read thread unblocks.
Optional `ssl` feature using rustls 0.23. Blocking and tokio clients get `connect_ssl`. Flush JSON-RPC writes so TLS buffers are pushed.
noahjoeris
force-pushed
the
feat/transport-address-types
branch
from
August 26, 2026 10:24
fc9d02c to
be23078
Compare
noahjoeris
changed the title
noahjoeris
marked this pull request as ready for review
August 26, 2026 10:42
Dispatch `tcp://` / `ssl://` URL strings to the TCP or TLS constructors for async and blocking clients. A missing scheme defaults to TCP.
noahjoeris
force-pushed
the
feat/transport-address-types
branch
from
August 26, 2026 18:32
be23078 to
4159049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #9
Adds built-in TCP and TLS connection support for async and blocking clients, plus a scheme-based
connectfacade supportingtcp://andssl://.Breaking: Raises MSRV from 1.70 to 1.71, required by rustls 0.23.
Notes to reviewers
StreamOwnedcannot be split into independent halves, sotransport/tls.rsprovides a split-capable adapter sharing the rustls state.Changelog notice