Skip to content

Fix positioning issues of callouts (#11183) #12302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msynk wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix positioning issues of callouts (#11183) #12302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57c9f6f
fix positioning issues of callouts #11183
msynk May 4, 2026
b76d476
Merge branch 'develop' into 11183-blazorui-callout-positioning-issues
msynk May 5, 2026
1f2a760
fix tests
msynk May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
275 changes: 138 additions & 137 deletions src/BlazorUI/Bit.BlazorUI/Components/Buttons/MenuButton/BitMenuButton.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,139 +1,140 @@
@namespace Bit.BlazorUI
@inherits BitComponentBase
@typeparam TItem
@namespace Bit.BlazorUI
@inherits BitComponentBase
@typeparam TItem

<CascadingValue Value="this" IsFixed="true">
<div style="display:none" hidden>@(Options ?? ChildContent)</div>
</CascadingValue>

@{
var _selectedItem = Sticky ? SelectedItem : null;
}
<div @ref="RootElement" @attributes="HtmlAttributes"
id="@_Id"
style="@StyleBuilder.Value"
class="@ClassBuilder.Value"
dir="@Dir?.ToString().ToLower()">
<button @onclick="() => HandleOnHeaderClick(_selectedItem)"
type="button"
tabindex="@(IsEnabled ? 0 : -1)"
aria-label="@AriaLabel"
aria-hidden="@AriaHidden"
aria-describedby="@AriaDescription"
style="@GetStyle(_selectedItem);@Styles?.OperatorButton"
class="bit-mnb-opb @GetClass(_selectedItem) @Classes?.OperatorButton">
@if (Sticky)
{
var template = GetTemplate(_selectedItem);
if (template is not null)
{
@template(_selectedItem!)
}
else if (ItemTemplate is not null)
{
@ItemTemplate(_selectedItem)
}
else
{
var icon = GetIcon(_selectedItem);
@if (icon is not null)
{
<i style="@Styles?.OperatorButtonIcon" class="@icon.GetCssClasses() @Classes?.OperatorButtonIcon" />
}
<span style="@Styles?.OperatorButtonText" class="bit-mnb-btx @Classes?.OperatorButtonText">
@GetText(_selectedItem)
</span>
}
}
else
{
var headerIcon = BitIconInfo.From(Icon, IconName);
@if (HeaderTemplate is not null)
{
@HeaderTemplate
}
else
{
@if (headerIcon is not null)
{
<i style="@Styles?.Icon" class="@headerIcon.GetCssClasses() @Classes?.Icon" />
}

@if (Text.HasValue())
{
<span style="@Styles?.Text" class="bit-mnb-btx @Classes?.Text">@Text</span>
}
}
}

@if (Split is false)
{
var chevronIcon = BitIconInfo.From(ChevronDownIcon, ChevronDownIconName ?? "ChevronRight bit-ico-r90");
<i style="@Styles?.ChevronDown" class="@chevronIcon?.GetCssClasses() @Classes?.ChevronDown" />
}
</button>

@if (Split)
{
<span style="@Styles?.Separator" class="bit-mnb-spb @Classes?.Separator"></span>

<button @onclick="OpenCallout"
type="button"
tabindex="@(IsEnabled ? 0 : -1)"
style="@Styles?.ChevronDownButton"
class="bit-mnb-chb @Classes?.ChevronDownButton">
@{
var chevronIcon = BitIconInfo.From(ChevronDownIcon, ChevronDownIconName ?? "ChevronRight bit-ico-r90");
}
<i style="@Styles?.ChevronDown" class="@chevronIcon?.GetCssClasses() @Classes?.ChevronDown" />
</button>
}
</div>

<CascadingValue Value="this" IsFixed="true">
<div style="display:none" hidden>@(Options ?? ChildContent)</div>
</CascadingValue>
<div @onclick="CloseCallout" @onclick:stopPropagation
style="display:@(IsOpen ? "block" : "none");@Styles?.Overlay"
id="@_overlayId"
class="bit-mnb-ovl @Classes?.Overlay"></div>

@{
var _selectedItem = Sticky ? SelectedItem : null;
}
<div @ref="RootElement" @attributes="HtmlAttributes"
id="@_Id"
style="@StyleBuilder.Value"
class="@ClassBuilder.Value"
dir="@Dir?.ToString().ToLower()">
<button @onclick="() => HandleOnHeaderClick(_selectedItem)"
type="button"
tabindex="@(IsEnabled ? 0 : -1)"
aria-label="@AriaLabel"
aria-hidden="@AriaHidden"
aria-describedby="@AriaDescription"
style="@GetStyle(_selectedItem);@Styles?.OperatorButton"
class="bit-mnb-opb @GetClass(_selectedItem) @Classes?.OperatorButton">
@if (Sticky)
{
var template = GetTemplate(_selectedItem);
if (template is not null)
{
@template(_selectedItem!)
}
else if (ItemTemplate is not null)
{
@ItemTemplate(_selectedItem)
}
else
{
var icon = GetIcon(_selectedItem);
@if (icon is not null)
{
<i style="@Styles?.OperatorButtonIcon" class="@icon.GetCssClasses() @Classes?.OperatorButtonIcon" />
}
<span style="@Styles?.OperatorButtonText" class="bit-mnb-btx @Classes?.OperatorButtonText">
@GetText(_selectedItem)
</span>
}
}
else
{
var headerIcon = BitIconInfo.From(Icon, IconName);
@if (HeaderTemplate is not null)
{
@HeaderTemplate
}
else
{
@if (headerIcon is not null)
{
<i style="@Styles?.Icon" class="@headerIcon.GetCssClasses() @Classes?.Icon" />
}

@if (Text.HasValue())
{
<span style="@Styles?.Text" class="bit-mnb-btx @Classes?.Text">@Text</span>
}
}
}

@if (Split is false)
{
var chevronIcon = BitIconInfo.From(ChevronDownIcon, ChevronDownIconName ?? "ChevronRight bit-ico-r90");
<i style="@Styles?.ChevronDown" class="@chevronIcon?.GetCssClasses() @Classes?.ChevronDown" />
}
</button>

@if (Split)
{
<span style="@Styles?.Separator" class="bit-mnb-spb @Classes?.Separator"></span>

<button @onclick="OpenCallout"
type="button"
tabindex="@(IsEnabled ? 0 : -1)"
style="@Styles?.ChevronDownButton"
class="bit-mnb-chb @Classes?.ChevronDownButton">
@{
var chevronIcon = BitIconInfo.From(ChevronDownIcon, ChevronDownIconName ?? "ChevronRight bit-ico-r90");
}
<i style="@Styles?.ChevronDown" class="@chevronIcon?.GetCssClasses() @Classes?.ChevronDown" />
</button>
}

<div @onclick="CloseCallout" @onclick:stopPropagation
style="display:@(IsOpen ? "block" : "none");@Styles?.Overlay"
class="bit-mnb-ovl @Classes?.Overlay"></div>

<div id="@_calloutId"
style="@Styles?.Callout"
class="bit-mnb-cal @Classes?.Callout">
<ul role="presentation" style="@Styles?.CalloutContainer" class="bit-mnb-cul @Classes?.CalloutContainer">
@foreach (var (item, idx) in _items.Select((item, idx) => (item, idx)))
{
if (Sticky && item == SelectedItem) continue;

var template = GetTemplate(item);
var isEnabled = GetIsEnabled(item);
<li role="presentation" @key="@GetItemKey(item, idx.ToString())" style="@Styles?.ItemWrapper" class="@Classes?.ItemWrapper">
<button @onclick="() => HandleOnItemClick(item)" @onclick:stopPropagation
role="menuitem"
type="@_buttonType.GetValue()"
tabindex="@(isEnabled ? 0 : -1)"
disabled="@(isEnabled is false)"
aria-disabled="@(isEnabled is false)"
style="@GetStyle(item);@Styles?.ItemButton"
class="bit-mnb-itm @GetClass(item) @Classes?.ItemButton">
@if (template is not null)
{
@template(item)
}
else if (ItemTemplate is not null)
{
@ItemTemplate(item)
}
else
{
var itemIcon = GetIcon(item);
@if (itemIcon is not null)
{
<i style="@Styles?.ItemIcon" class="bit-mnb-iic @itemIcon.GetCssClasses() @Classes?.ItemIcon" />
}
<span style="@Styles?.ItemText" class="bit-mnb-btx @Classes?.ItemText">
@GetText(item)
</span>
}
</button>
</li>
}
</ul>
</div>
</div>
<div id="@_calloutId"
style="@Styles?.Callout"
class="bit-mnb-cal @Classes?.Callout">
<ul role="presentation" style="@Styles?.CalloutContainer" class="bit-mnb-cul @Classes?.CalloutContainer">
@foreach (var (item, idx) in _items.Select((item, idx) => (item, idx)))
{
if (Sticky && item == SelectedItem) continue;

var template = GetTemplate(item);
var isEnabled = GetIsEnabled(item);
<li role="presentation" @key="@GetItemKey(item, idx.ToString())" style="@Styles?.ItemWrapper" class="@Classes?.ItemWrapper">
<button @onclick="() => HandleOnItemClick(item)" @onclick:stopPropagation
role="menuitem"
type="@_buttonType.GetValue()"
tabindex="@(isEnabled ? 0 : -1)"
disabled="@(isEnabled is false)"
aria-disabled="@(isEnabled is false)"
style="@GetStyle(item);@Styles?.ItemButton"
class="bit-mnb-itm @GetClass(item) @Classes?.ItemButton">
@if (template is not null)
{
@template(item)
}
else if (ItemTemplate is not null)
{
@ItemTemplate(item)
}
else
{
var itemIcon = GetIcon(item);
@if (itemIcon is not null)
{
<i style="@Styles?.ItemIcon" class="bit-mnb-iic @itemIcon.GetCssClasses() @Classes?.ItemIcon" />
}
<span style="@Styles?.ItemText" class="bit-mnb-btx @Classes?.ItemText">
@GetText(item)
</span>
}
</button>
</li>
}
</ul>
</div>
3 changes: 3 additions & 0 deletions src/BlazorUI/Bit.BlazorUI/Components/Buttons/MenuButton/BitMenuButton.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public partial class BitMenuButton<TItem> : BitComponentBase where TItem : class
private List<TItem> _items = [];
private BitButtonType _buttonType;
private string _calloutId = default!;
private string _overlayId = default!;
private IEnumerable<TItem> _oldItems = default!;
private DotNetObjectReference<BitMenuButton<TItem>> _dotnetObj = default!;

Expand Down Expand Up @@ -271,6 +272,7 @@ protected override void RegisterCssStyles()
protected override async Task OnInitializedAsync()
{
_calloutId = $"BitMenuButton-{UniqueId}-callout";
_overlayId = $"BitMenuButton-{UniqueId}-overlay";

if (Sticky && SelectedItemHasBeenSet is false && DefaultSelectedItem is not null)
{
Expand Down Expand Up @@ -617,6 +619,7 @@ await _js.BitCalloutToggleCallout(
component: null,
calloutId: _calloutId,
callout: null,
overlayId: _overlayId,
isCalloutOpen: IsOpen,
responsiveMode: BitResponsiveMode.None,
dropDirection: BitDropDirection.TopAndBottom,
Expand Down
Loading
Loading