[BCN] fix duplicate native EVM receive history rows#4181
Open
msalcala11 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes duplicate native EVM receive history rows.
For some transactions, the EVM trace includes a top-level call at call stack
0that moves the chain's native coin, like MATIC or ETH. Bitcore turns that trace call into an effect. In this case, the effect is not a separate internal transfer; it is just another representation of the transaction's ownfrom,to, andvalue.Before this change, wallet history treated that root effect as an extra receive and also emitted the original transaction receive, which doubled the amount shown for that transaction.
Changelog
Testing Notes
npm run test:integration
Checklist