fix(target): treat dependencies and buildPhases as optional keys#335
Draft
Badlazzor wants to merge 1 commit into
Draft
fix(target): treat dependencies and buildPhases as optional keys#335Badlazzor wants to merge 1 commit into
Badlazzor wants to merge 1 commit into
Conversation
Xcode 16.2+ omits the 'dependencies' key from project.pbxproj when a target has no dependencies (instead of writing 'dependencies = ();'). parseTarget() must therefore treat the key as optional. The same forward-compat guard is applied to 'buildPhases'. Ports the v1 fix landed in #331 (v1.3.4) onto the xcodeproject-v2 branch, and adds a unit test covering the omitted-keys case so regressions on either key are caught. Related: STEP-2426.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the v1 fix landed in #331 (released as
v1.3.4) onto thexcodeproject-v2branch, plus a unit test covering the omitted-keys case.Xcode 16.2+ omits the
dependencieskey entirely fromproject.pbxprojwhen a target has no dependencies (instead of writingdependencies = ();). The same forward-compat guard is applied tobuildPhases.Changes
xcodeproject/xcodeproj/target.go— sameIsKeyNotFoundErrorguard already used forproductType/productReferenceextended todependenciesandbuildPhases. Mirror of fix(target): treat dependencies and buildPhases as optional keys #331.xcodeproject/xcodeproj/target_test.go— newrawNativeTargetOmittedKeysfixture + test case underTestParseTarget. AssertsparseTargetreturns no error and emptyDependencies/buildPhaseIDswhen both keys are absent.Testing
All existing tests pass. New subtest exercises the omitted-keys path.
Context
xcodeproject-v2migration is owned by @lpusok; happy to take review and adjustments.