Skip to content

fix: missing compilation flag on recent msvc version #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Titus-von-Koeller merged 3 commits into from
Aug 12, 2026
+9 −3
Merged

fix: missing compilation flag on recent msvc version #2032

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b459659
fix: missing compilation flag on recent msvc version
mfuntowicz Aug 3, 2026
d799cfd
Gate /Zc:preprocessor to cl.exe only
mfuntowicz Aug 12, 2026
0330f40
Merge branch 'main' into fix/cuda_121_win
mfuntowicz Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,12 +338,18 @@ if(WIN32)
endif()

if(MSVC)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /fp:fast")

# Only real cl.exe needs (and accepts) the conformant preprocessor switch;
# clang-cl / icx are already conformant and warn on it.
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zc:preprocessor")
endif()

# /arch:AVX2 is only valid for x86/x64 targets, not ARM64
string(TOLOWER "${CMAKE_SYSTEM_PROCESSOR}" _msvc_arch)
if(_msvc_arch MATCHES "x86|x64|amd64")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /arch:AVX2 /fp:fast")
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /fp:fast")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /arch:AVX2")
endif()
endif()

Expand Down