chore(deps): bump @pkcprotocol/pkc-js devDependency to 0.0.94 - #46
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates the ChangesDevelopment Dependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0.0.93 carries the late-listener RPC fix (pkcprotocol/pkc-js#299, delivering subscribe-time errors to update/publish/start listeners that attach after the failure). Typecheck, examples, tests, build, the 509-test unit suite with coverage and the 12-test two-node gossipsub integration suite all pass unchanged.
d5f547b to
641d3a6
Compare
0.0.94 is the first release carrying `perf(community): drive kubo/helia updates from gossip pushes instead of a 1s poll` (pkcprotocol/pkc-js#311, issues #308/#307), plus the RPC destroy()/websocket-close fix (#326). Measured on pubsub-voting-testing-on-real-website (real Chromium, cold profile, 63 contests + 64 communities, 60s cold + 300s steady): steady CPU 24.1% -> 8.5% of a core, renderer main-thread task time 43.6s -> 10.3s per 5 min, peak RSS 1383 -> 1249 MiB. Cold-start behaviour unchanged. The lockfile is regenerated with npm 10 (what actions/setup-node node-22 ships); regenerating with local npm 11 drops utf-8-validate and npm ci then refuses the tree.
Bumps the
@pkcprotocol/pkc-jsdevDependency from 0.0.92 to 0.0.94 (the current npmlatest).0.0.94 is the first release carrying
perf(community): drive kubo/helia updates from gossip pushes instead of a 1s poll(pkcprotocol/pkc-js#311, issues #308/#307). It also picks upfix(rpc): deliver subscribe-time errors to late listeners(#299, from 0.0.93) andfix(rpc): make client and server destroy() wait for their websockets to close(#326).The lockfile is regenerated with npm 10 (the npm
actions/setup-nodenode-22 ships), same as 5b1728b on the 0.0.92 branch — regenerating with local npm 11 dropsutf-8-validate@5.0.10andnpm cithen refuses the tree.Verified locally, all green and unchanged from master
npm run typecheck,typecheck:examples,typecheck:tests,npm run buildvitest run— 38 files, 509 tests passednpm run test:integration— 3 files, 12 tests passedThe perf fix is real: ~65% less steady CPU in the browser
Measured on the pubsub-voting-testing-on-real-website site (real Chromium, cold profile, 63 contests + 64 communities, whole-Chromium-process-tree CPU from /proc, 60 s cold start + 300 s steady window):
Three shorter rounds (60 s + 120 s) agree: 0.0.92 averaged 23.7% of a core, 0.0.94 averaged 10.4%.
The burn on 0.0.92/0.0.93 was
updatingstatechangechurn — 63 subscribed communities × 2 transitions/s (waiting-retry↔fetching-ipns) = ~128 events/s, steady and unbounded, because it was a poll rather than real work. 0.0.94 parks the loop on gossip pushes and the churn drops to ~8 events/s.Cold-start behaviour is unchanged across every configuration: 64 communities loaded, 64/64 joins succeeded, 64 first-tallies, in every round.
Summary by CodeRabbit