Skip to content

Breakdown tasks skill#144

Merged
trmartin4 merged 59 commits into
mainfrom
tech-breakdown-tasks-skill
Jun 23, 2026
Merged

Breakdown tasks skill#144
trmartin4 merged 59 commits into
mainfrom
tech-breakdown-tasks-skill

Conversation

@trmartin4

@trmartin4 trmartin4 commented Jun 12, 2026

Copy link
Copy Markdown
Member

📔 Objective

Adds the next in a sequence of changes to decompose and enhance the existing writing-tech-breakdowns skill, for use with our new tech-breakdowns repo.

Base automatically changed from tech-breakdown-plan-skill to main June 19, 2026 10:49
@trmartin4 trmartin4 marked this pull request as ready for review June 19, 2026 16:12
@trmartin4 trmartin4 requested a review from a team as a code owner June 19, 2026 16:12
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR continues the decomposition of the tech-breakdown skills: it removes the two superseded skills (writing-tech-breakdowns, coordinating-cross-team-breakdown), adds the new decomposing-into-tasks skill, and updates all cross-references in developing-breakdown-spec, navigating-the-initiative-funnel, and the tech-lead AGENT.md. The breaking removals are correctly reflected in a major version bump of bitwarden-delivery-tools (1.5.0 → 2.0.0) with a matching changelog entry, and bitwarden-tech-lead gets a patch bump (2.3.1 → 2.3.2) for its reference updates. I verified no live references to the removed skills remain outside of historical CHANGELOG entries.

Code Review Details
  • 🎨 : Acceptance Criteria format ordering reversed — should be GIVEN/WHEN/THEN (Gherkin), not GIVEN/THEN/WHEN
    • plugins/bitwarden-delivery-tools/skills/decomposing-into-tasks/SKILL.md:104

Notes on items checked and cleared:

  • Version bumps and changelog entries are present and semantically correct (major bump for the breaking skill removals).
  • No dangling references to the removed skills in any active SKILL.md, AGENT.md, README, or plugin.json — only in CHANGELOG history, which is correct.
  • The new skill's use of AskUserQuestion/TaskCreate without listing them in allowed-tools matches the established convention of sibling breakdown skills.
  • New cspell terms (duplicative, MECE, narratively) cover the vocabulary introduced.

Comment thread plugins/bitwarden-delivery-tools/skills/decomposing-into-tasks/SKILL.md Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

@theMickster theMickster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor thoughts for discussion; nothing blocking with those.

Let's fix up that changelog though

Comment thread plugins/bitwarden-tech-lead/CHANGELOG.md
Comment thread plugins/bitwarden-delivery-tools/skills/decomposing-into-tasks/SKILL.md Outdated
@trmartin4 trmartin4 requested a review from theMickster June 23, 2026 11:34
theMickster
theMickster previously approved these changes Jun 23, 2026
@trmartin4

trmartin4 commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

Had to address a merge conflict.

@trmartin4 trmartin4 requested a review from theMickster June 23, 2026 14:36
@theMickster

Copy link
Copy Markdown
Contributor

Had to address a merge conflict.

Sorry! I think that was me merging in the work for the multi agent code review.

@trmartin4 trmartin4 merged commit 49443fd into main Jun 23, 2026
13 checks passed
@trmartin4 trmartin4 deleted the tech-breakdown-tasks-skill branch June 23, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants