Skip to content

[PM-39432] chore: pass null Send repository in SdkRepositoryFactoryImpl#7120

Merged
adudek-bw merged 5 commits into
sdlc/sdk-updatefrom
pm-39432/sdk-send-repository-noop
Jul 1, 2026
Merged

[PM-39432] chore: pass null Send repository in SdkRepositoryFactoryImpl#7120
adudek-bw merged 5 commits into
sdlc/sdk-updatefrom
pm-39432/sdk-send-repository-noop

Conversation

@adudek-bw

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39432

📔 Objective

Paired with bitwarden/sdk-internal#1217, which adds a Send slot to the SDK's client-managed Repositories struct (via the create_client_managed_repositories! macro in bitwarden-pm/src/migrations.rs). The new field surfaces through the UniFFI Kotlin binding as a required send constructor parameter on com.bitwarden.sdk.Repositories.

This PR adds send = null to the call site in SdkRepositoryFactoryImpl so the Kotlin code compiles against the new SDK. No behavioral change — Android doesn't persist Sends locally today, so passing null matches the existing pattern used for folder, userKeyState, ephemeralPinEnvelopeState, and organizationSharedKey.

Without this paired change, the SDK PR's breaking-change detection job for Android fails with:

e: SdkRepositoryFactoryImpl.kt:37:13 No value passed for parameter 'send'.

When Android starts persisting Sends locally, this null can be replaced with a real SdkSendRepository implementation, similar to how cipher and localUserDataKeyState work today.

📸 Screenshots

N/A — no UI changes.

Paired with bitwarden/sdk-internal#1217, which adds a Send slot to the
SDK's client-managed Repositories struct. Until Android needs to persist
Sends locally, pass null so the constructor compiles. No behavioral
change.
@adudek-bw adudek-bw requested review from a team and david-livefront as code owners June 30, 2026 12:41
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt labels Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the single-line addition of send = null to the Repositories(...) constructor call in SdkRepositoryFactoryImpl. The change aligns the Kotlin code with the paired SDK PR that adds a required send parameter, and it follows the established convention for other unpersisted repository slots in the same file (folder, userKeyState, ephemeralPinEnvelopeState, organizationSharedKey). No behavioral change, no security or correctness concerns.

Code Review Details

No findings. The change is a no-op compilation fix that matches the existing null-slot pattern, is well-documented in the PR description, and references PM-39432 along with the paired SDK PR.

@vvolkgang vvolkgang added the hold do not merge yet label Jun 30, 2026
@vvolkgang

Copy link
Copy Markdown
Member

On hold until bitwarden/sdk-internal#1217 is merged.

adudek-bw added a commit to bitwarden/sdk-internal that referenced this pull request Jul 1, 2026
## 🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39432

## 📔 Objective

Expose a client-managed send repository so clients can register a
Repository<Send> with the SDK.

## 🚨 Breaking Changes

clients change: bitwarden/clients#21579
android change: bitwarden/android#7120
@github-actions github-actions Bot added the app:authenticator Bitwarden Authenticator app context label Jul 1, 2026
@adudek-bw adudek-bw removed the hold do not merge yet label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (sdlc/sdk-update@795659d). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             sdlc/sdk-update    #7120   +/-   ##
==================================================
  Coverage                   ?   86.12%           
==================================================
  Files                      ?      885           
  Lines                      ?    64385           
  Branches                   ?     9580           
==================================================
  Hits                       ?    55449           
  Misses                     ?     5492           
  Partials                   ?     3444           
Flag Coverage Δ
app-data 17.58% <100.00%> (?)
app-ui-auth-tools 18.76% <0.00%> (?)
app-ui-platform 16.49% <0.00%> (?)
app-ui-vault 27.52% <0.00%> (?)
authenticator 6.18% <0.00%> (?)
lib-core-network-bridge 4.03% <0.00%> (?)
lib-data-ui 1.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

),
ephemeralPinEnvelopeState = null,
organizationSharedKey = null,
send = null,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to implement this any time soon?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless it's already on your roadmap :)

@adudek-bw adudek-bw changed the base branch from main to sdlc/sdk-update July 1, 2026 18:34
@adudek-bw adudek-bw requested a review from a team as a code owner July 1, 2026 18:34
@github-actions github-actions Bot removed the app:authenticator Bitwarden Authenticator app context label Jul 1, 2026
@adudek-bw adudek-bw requested a review from david-livefront July 1, 2026 18:42
@adudek-bw adudek-bw merged commit 05f8bac into sdlc/sdk-update Jul 1, 2026
21 checks passed
@adudek-bw adudek-bw deleted the pm-39432/sdk-send-repository-noop branch July 1, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants