[PM-39432] chore: pass null Send repository in SdkRepositoryFactoryImpl#7120
Conversation
Paired with bitwarden/sdk-internal#1217, which adds a Send slot to the SDK's client-managed Repositories struct. Until Android needs to persist Sends locally, pass null so the constructor compiles. No behavioral change.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the single-line addition of Code Review DetailsNo findings. The change is a no-op compilation fix that matches the existing null-slot pattern, is well-documented in the PR description, and references PM-39432 along with the paired SDK PR. |
|
On hold until bitwarden/sdk-internal#1217 is merged. |
## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-39432 ## 📔 Objective Expose a client-managed send repository so clients can register a Repository<Send> with the SDK. ## 🚨 Breaking Changes clients change: bitwarden/clients#21579 android change: bitwarden/android#7120
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sdlc/sdk-update #7120 +/- ##
==================================================
Coverage ? 86.12%
==================================================
Files ? 885
Lines ? 64385
Branches ? 9580
==================================================
Hits ? 55449
Misses ? 5492
Partials ? 3444
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| ), | ||
| ephemeralPinEnvelopeState = null, | ||
| organizationSharedKey = null, | ||
| send = null, |
There was a problem hiding this comment.
Do we need to implement this any time soon?
There was a problem hiding this comment.
Not unless it's already on your roadmap :)
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39432
📔 Objective
Paired with bitwarden/sdk-internal#1217, which adds a
Sendslot to the SDK's client-managedRepositoriesstruct (via thecreate_client_managed_repositories!macro inbitwarden-pm/src/migrations.rs). The new field surfaces through the UniFFI Kotlin binding as a requiredsendconstructor parameter oncom.bitwarden.sdk.Repositories.This PR adds
send = nullto the call site inSdkRepositoryFactoryImplso the Kotlin code compiles against the new SDK. No behavioral change — Android doesn't persist Sends locally today, so passingnullmatches the existing pattern used forfolder,userKeyState,ephemeralPinEnvelopeState, andorganizationSharedKey.Without this paired change, the SDK PR's breaking-change detection job for Android fails with:
When Android starts persisting Sends locally, this
nullcan be replaced with a realSdkSendRepositoryimplementation, similar to howcipherandlocalUserDataKeyStatework today.📸 Screenshots
N/A — no UI changes.