Conversation
liquidsec
marked this pull request as draft
July 10, 2026 17:20
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #3297 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 450 450
Lines 46229 46251 +22
=====================================
+ Hits 41484 41509 +25
+ Misses 4745 4742 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bbot/presets/web/js-audit.yml(invoked as-p js-audit) for hunting leaked credentials and vulnerable libraries in client-side JavaScript. Enableshttp,trufflehog,badsecrets,retirejs,robots,wayback.trufflehog stdininstead of writing them to a tempfile.data["url"], so an operator can trace a leaked secret back to the exact JS bundle.Why
BBOT has no native workflow for hunting secrets in client-side JavaScript. Trufflehog already watches HTTP_RESPONSE but it's
code-enum-flagged and doesn't get pulled in by any web-focused preset. Buildingjs-auditsurfaced two latent issues in the trufflehog module that made the output unusable for this workflow:~/.bbot/temp/xxxbefore scanning. Wasted disk I/O per response, doubles up with body-spill in configs that use it, and the tempfile path leaked intosource_metadatain the FINDING description.Details: [{'Data': {'Filesystem': {'file': '/home/liquid/.bbot/temp/2av150lh9hz23qxjpr6r', 'line': 13}}}]with no way to correlate that to the specific JS file.What changed
trufflehog module
trufflehog filesystem <tempfile>totrufflehog stdin, piped viarun_process_live(..., input=body). No tempfile.Details:field now showsStdin: {}instead of a tempfile path.data["url"]from the parent HTTP_RESPONSE.self.helpers.run_livetoself.run_process_liveso the trufflehog subprocess is tracked in_proc_trackerand cleaned up on scan shutdown, matching the pattern used by fingerprintx, gowitness, and nuclei.Preset
bbot/presets/web/js-audit.yml. Config:trufflehog.only_verified: false(broad detection),robots.include_sitemap: true(sitemaps often enumerate JS bundle paths),wayback.urls: true+archive: true(secrets in deprecated/archived JS is a classic hunting ground).