Fix SonarCloud S8970 null-forgiving smell (1 real, 23 FP)

[blehnen]

What

SonarCloud rolled out two new rules that flagged existing code:

• S8970 (redundant null-forgiving !) — 24 hits
• S8949 (pass CancellationToken) — 1 hit

Of the 24 S8970 hits, only one is real: DashboardExtensions.cs:176. That file is in a nullable-disabled context (Dashboard.Api has no <Nullable>enable>), so the ! on displayName was a genuine no-op. Removed it.

The other 23 S8970 hits are analyzer false positives. They live in Dashboard.Ui razor files, and that project sets <Nullable>enable</Nullable> — the razor @code blocks honor it, so those ! operators are load-bearing. Proven empirically: removing MessageId! produces CS8604 (possible null reference argument). Sonar mis-detects the nullable context of razor-generated code. Marked false-positive in SonarCloud.

The 1 S8949 bug is also a false positive and marked accordingly: the _monitorCompleted.Wait(30s) in BaseMonitor.Cancel() runs after CancelToken.Cancel() — passing the (already-cancelled) token would abort the safety-net wait immediately, defeating its purpose.

Result

• Code: 1 line changed, Release build clean (0 warnings, net8.0 + net10.0).
• SonarCloud: 24 issues transitioned to false-positive; this PR clears the last one on rescan → back to 0 bugs / 0 open smells from this batch.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved nullability handling during dashboard connection setup without changing runtime behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fe29877-8f99-4b82-a429-3fd81cb6803a

📥 Commits

Reviewing files that changed from the base of the PR and between f031387 and 12d6a1e.

📒 Files selected for processing (1)

• Source/DotNetWorkQueue.Dashboard.Api/DashboardExtensions.cs

---

📝 Walkthrough

Walkthrough

The dashboard transport initialization now passes displayName without the null-forgiving operator; runtime behavior and configuration flow remain unchanged.

Changes

Dashboard transport wiring

Layer / File(s)	Summary
Display name nullability cleanup Source/DotNetWorkQueue.Dashboard.Api/DashboardExtensions.cs	AddConnectionByTransport(...) now receives displayName directly instead of displayName!.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit hopping light,
Null-forcing gone from sight.
The display name passes through,
Configuration stays true.
One small change, neat and bright!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main SonarCloud null-forgiving cleanup, including the real fix and the false positives.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.45%. Comparing base (dce577b) to head (12d6a1e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   90.50%   90.45%   -0.05%     
==========================================
  Files        1022     1022              
  Lines       33476    33476              
  Branches     2790     2790              
==========================================
- Hits        30298    30282      -16     
+ Misses       2298     2289       -9     
- Partials      880      905      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.