Skip to content

Perf: Optimize string concatenation using .join() #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allrob23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Perf: Optimize string concatenation using .join() #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions utests/test_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,54 +103,42 @@ def test_log_response(mocked_logger):


def test_format_data_to_log_string_truncated_1():
data = ''
for i in range(0, 10000):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 10000))
truncated = format_data_to_log_string(data, 9999)
assert truncated == data[:9999] + '... (set the log level to DEBUG or TRACE to see the full content)'


def test_format_data_to_log_string_truncated_2():
data = ''
for i in range(0, 10):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 10))
truncated = format_data_to_log_string(data, 0)
assert truncated == '... (set the log level to DEBUG or TRACE to see the full content)'


def test_format_data_to_log_string_truncated_3():
data = ''
for i in range(0, 10):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 10))
truncated = format_data_to_log_string(data, 10)
assert truncated == data


@mock.patch('HttpxLibrary.log.logging')
def test_format_data_not_truncate_debug_level(mocked_logger):
data = ''
for i in range(0, 100001):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 100001))
mocked_logger.getLogger().level = 10
truncated = format_data_to_log_string(data)
assert truncated == data


@mock.patch('HttpxLibrary.log.logging')
def test_format_data_not_truncate_trace_level(mocked_logger):
data = ''
for i in range(0, 100001):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 100001))
mocked_logger.getLogger().level = 0
truncated = format_data_to_log_string(data)
assert truncated == data


@mock.patch('HttpxLibrary.log.logging')
def test_format_data_truncate_info_level(mocked_logger):
data = ''
for i in range(0, 100001):
data = data + str(i)
data = ''.join(str(i) for i in range(0, 100001))
mocked_logger.getLogger().level = 20
truncated = format_data_to_log_string(data)
assert truncated == data[:10000] + '... (set the log level to DEBUG or TRACE to see the full content)'