Repository navigation
Conversation
A double-click on "Setup with AI" during ASC onboarding launched the same claude session in two Terminal windows, so the asc-team-key-create skill ran twice and created two API keys. TerminalLauncher.launch runs osascript synchronously on the main thread with no in-flight guard, so a second click is queued and replayed right after the first launch returns. Dedupe identical launch commands within a 3s window measured from the end of the launch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The duplicate-launch guard recorded every launch, including failures, so retrying within 3s after a failed launch was skipped and reported as success. Forget the launch when it fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Covers: a replayed click inside the window is skipped, the same command is allowed after the window, a failed launch doesn't block a retry, and a different command is never blocked. Verified the test fails when the failed-launch reset is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The onboarding setup agent could be launched twice in quick succession, which started two agent sessions. In our case the two sessions created two App Store Connect API keys, and one had to be revoked.
Fix
TerminalLauncherignores an identical agent launch request that arrives within 3 seconds of the previous one.TerminalLauncherDuplicateLaunchTestscovers the duplicate guard.Testing
Running in a local build of 1.0.35 since 2026-10-14. Note: on current master the test target doesn't compile because of 4 unrelated files (ASCProjectLifecycle, DashboardSummaryStore, ASCScreenshotsLocaleRegression, ASCVersionSelection tests), so the new test hasn't been run through the full test target here.
🤖 Generated with Claude Code