Skip to content

Fixed a few issues running InverseCrossAttention_Release.ipynb#19

Open
nielsrolf wants to merge 1 commit intobloc97:mainfrom
nielsrolf:main
Open

Fixed a few issues running InverseCrossAttention_Release.ipynb#19
nielsrolf wants to merge 1 commit intobloc97:mainfrom
nielsrolf:main

Conversation

@nielsrolf
Copy link
Copy Markdown

Super cool project, thanks a lot! I had a few minor issues running the InverseCrossAttention_Release.ipynb that I fixed here, mainly installing the libraries and downloading the sample image. I thought I make a pr so that we don't all have to do this as the first step

@bloc97
Copy link
Copy Markdown
Owner

bloc97 commented Oct 14, 2022

I'm not sure we would want a !pip install inside of a jupyter notebook. It is fine to use in colab as the environment is already set up, but using this with a standard jupyter can break a user's environment. !pip install ignores the jupyter kernel and all variables/settings associated with it...

Would you like to rather make a colab notebook with the pip installs instead? You can edit the readme to include it next to the last contributor for the colab notebook. Sorry for the nitpick but it's rather annoying to have to reinstall conda due to a broken environment...
Edit: Thanks for the contribution by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants