Fixed a few issues running InverseCrossAttention_Release.ipynb#19
Open
nielsrolf wants to merge 1 commit intobloc97:mainfrom
Open
Fixed a few issues running InverseCrossAttention_Release.ipynb#19nielsrolf wants to merge 1 commit intobloc97:mainfrom
nielsrolf wants to merge 1 commit intobloc97:mainfrom
Conversation
Owner
|
I'm not sure we would want a !pip install inside of a jupyter notebook. It is fine to use in colab as the environment is already set up, but using this with a standard jupyter can break a user's environment. Would you like to rather make a colab notebook with the pip installs instead? You can edit the readme to include it next to the last contributor for the colab notebook. Sorry for the nitpick but it's rather annoying to have to reinstall conda due to a broken environment... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super cool project, thanks a lot! I had a few minor issues running the InverseCrossAttention_Release.ipynb that I fixed here, mainly installing the libraries and downloading the sample image. I thought I make a pr so that we don't all have to do this as the first step