fix(desktop): classify timeline prepends so history loads don't bump unread#1416
Open
wesbillman wants to merge 1 commit into
Open
fix(desktop): classify timeline prepends so history loads don't bump unread#1416wesbillman wants to merge 1 commit into
wesbillman wants to merge 1 commit into
Conversation
wesbillman
force-pushed
the
pinky/e2e-scroll-contract
branch
from
6e9119b to
5deaeb6
Compare
…unread Treat timeline prepends as a distinct message delta so older-history pages do not look like new unread arrivals when the newest row is unchanged. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/e2e-scroll-contract
branch
from
5deaeb6 to
5350f04
Compare
wesbillman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classifyTimelineMessageDelta) so older-history prepends are distinct from latest-message appendsuseAnchoredScrollso older history does not increment the new-message affordanceRebased on main; the earlier
persona-env-vars.spec.tshardening was dropped because main already landed an equivalentselectDropdownOptionhelper in #1396.Validation
cd desktop && pnpm buildcd desktop && node --import ./test-loader.mjs --experimental-strip-types --test src/features/messages/lib/timelineSnapshot.test.mjs(44/44)cd desktop && pnpm exec playwright test --project=smoke tests/e2e/scroll-history.spec.ts -g "older-history prepend keeps" --repeat-each=5Note: the "older-history prepend keeps the reading row fixed" spec is flaky locally on unmodified
origin/mainas well (2/5 failures there vs 1/5 on this branch, timeout in initialwaitForFunction), so that flake is pre-existing and not addressed here.