fix(desktop): quiet gate for workspace switches instead of boot splash#1449
Open
wesbillman wants to merge 1 commit into
Open
fix(desktop): quiet gate for workspace switches instead of boot splash#1449wesbillman wants to merge 1 commit into
wesbillman wants to merge 1 commit into
Conversation
Switching workspaces via the rail replayed the full cold-boot splash
("Setting up your workspace..." with its rise animation) for the brief
moment apply_workspace runs, making every switch jarring. Latch once the
workspace key deviates from its cold-boot value and render a quiet gate
(plain background, spinner only after 300ms) for switches. Cold boot and
first-run onboarding keep the existing splash.
Adds an applyWorkspaceDelayMs mock knob so the e2e test can observe the
gate deterministically.
Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the workspace rail, every workspace switch flashed the full cold-boot splash — "Setting up your workspace..." with its character-rise animation replaying from zero — for the brief moment
apply_workspaceruns. Fast switches got a jarring full-screen blast.Fix
App.tsxlatches once the composite workspace key deviates from its cold-boot value. From then on, loading phases are in-app switches and render a new quietWorkspaceSwitchGate: plain themed background, spinner only if the switch takes >300ms. Typical switches are now just a brief neutral blink.Unchanged:
OnboardingLoadingGate.Testing
workspace-rail.spec.ts: slowsapply_workspacevia a newapplyWorkspaceDelayMsmock knob, asserts cold boot shows the splash, then asserts a switch shows the quiet gate and the splash never reappears.just desktop-typecheck,just desktop-checkgreen.channels.spec.ts:867,scroll-history.spec.ts:288,timeline-no-shift.spec.ts:205) are scroll-timing specs that fail identically on unmodified main (verified by stashing this change and rerunning) — pre-existing flakes, unrelated.