consolidate agent profile runtime details#1451
Draft
tellaho wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Revert the runtime provenance lower-line copy to the wording on main: 'Set in Buzz', 'Inherited from persona', 'From environment variable (...)', 'From config file (...)', and 'From ACP session' — and stop suppressing the buzzExplicit provenance line. Restores the matching e2e assertions and mock-fixture comment. IA consolidation, Runtime tab split, and copy affordances are unchanged. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
a36743e to
2f6d48f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Agent profiles present runtime configuration in a cleaner, easier-to-scan Runtime tab.
Problem: Runtime metadata in the agent profile panel had drifted into a redundant, mixed-detail presentation that repeated model/instructions information and did not follow the panel’s existing information architecture. That made it harder to distinguish core runtime facts from configuration provenance.
Solution: Consolidate profile runtime details into the existing icon-row card pattern while preserving the pre-branch provenance copy (
Set in Buzz,Inherited from persona,From config file,From ACP session, etc.). Sparse declared-owner cases stay honest instead of rendering empty placeholders.File changes
desktop/src/features/agents/ui/AgentConfigPanel.tsx
Aligns the runtime config surface with the profile panel card pattern, including copy affordances and read-only lock treatment, while keeping the existing provenance wording.
desktop/src/features/profile/ui/UserProfilePanel.tsx
Updates the profile panel composition so agent-owned runtime details are exposed through the consolidated Runtime tab.
desktop/src/features/profile/ui/UserProfilePanelAgentDetails.tsx
Simplifies the agent-details presentation and removes redundant runtime/instructions dumping from the profile surface.
desktop/src/features/profile/ui/UserProfilePanelFields.tsx
Reuses the shared label/value row treatment for runtime fields and copyable profile metadata.
desktop/src/features/profile/ui/UserProfilePanelSections.tsx
Adjusts the section layout so runtime metadata fits the same visual rhythm as the rest of the profile panel.
desktop/src/features/profile/ui/UserProfilePanelTabs.tsx
Updates tab availability for managed and declared-owned agents so Runtime appears only where it has meaningful content.
desktop/src/testing/e2eBridge.ts
Extends profile/config test fixtures for the runtime metadata states covered by the profile panel.
desktop/tests/e2e/config-bridge-screenshots.spec.ts
Updates screenshot bridge coverage for the consolidated profile panel render path and restored provenance wording.
desktop/tests/e2e/profile.spec.ts
Adds regression coverage for declared-owner runtime visibility and sparse/no-relay-record behavior.
desktop/tests/helpers/bridge.ts
Adds helper support needed by the profile runtime test fixtures.
Reproduction Steps
Set in Buzz,Inherited from persona,From config file,From ACP session,From environment variable (...)).Screenshots/Demos
Runtime-only examples from the final review pass. These are real e2e renders after restoring the pre-branch provenance labels.
kind:10100recordFinal gate validation:
biome check .— cleanpnpm typecheck— cleanplaywright config-bridge-screenshots --project=smoke— 6/6 passed