Skip to content

fix(desktop): defer timeline trim past StrictMode probe#1478

Open
tlongwell-block wants to merge 1 commit into
fix/timeline-cap-evictionfrom
wren/fix-missing-history
Open

fix(desktop): defer timeline trim past StrictMode probe#1478
tlongwell-block wants to merge 1 commit into
fix/timeline-cap-evictionfrom
wren/fix-missing-history

Conversation

@tlongwell-block

Copy link
Copy Markdown
Collaborator

Summary

  • defer leave-time timeline trimming by one task so React StrictMode's synthetic setup → cleanup → setup cycle cannot trim an actively mounted channel
  • cancel a pending trim when the same channel subscription sets up again
  • keep the bounded-cache behavior on a real channel leave
  • add focused scheduler regressions for cancellation, real leave, and channel-key isolation

Context

This is stacked on #1473. #1473 removes cap-driven eviction from active timeline merges; this follow-up makes its leave-time cleanup safe under the app's React.StrictMode mount probe.

This does not address the separate ancestor-island paging cursor bug. That contiguous-frontier fix is being developed separately and must compose with this patch before the missing-history freeze is lifted.

Validation

  • desktop tests: 1497 passed, 0 failed
  • desktop typecheck: clean
  • pnpm check: clean
  • full pre-commit hooks: clean
  • pre-push hooks with the repo-pinned Hermit/Rust 1.95 toolchain: clean

An initial push attempt used Homebrew Rust 1.89 and correctly failed the buzz-db MSRV gate (sqlx 0.9 requires Rust 1.94). Re-running under the repository's pinned Hermit environment passed all hooks.

Co-authored-by: npub12gtutshhh76rx0jx697f32f9tffd4hhp3hx58fp4x6u4uemkm7sqf8f757 <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub12gtutshhh76rx0jx697f32f9tffd4hhp3hx58fp4x6u4uemkm7sqf8f757 <5217c5c2f7bfb4333e46d17c98a9255a52dadee18dcd43a43536b95e6776dfa0@sprout-oss.stage.blox.sqprod.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant