fix(desktop): accept just-now channel activity in tooltip spec - #6469
Open
Maxwellimus wants to merge 1 commit into
Open
fix(desktop): accept just-now channel activity in tooltip spec#6469Maxwellimus wants to merge 1 commit into
Maxwellimus wants to merge 1 commit into
Conversation
The channel-link tooltip expectation added in #6252 only allows 'Active Nm ago', but the spec sends a message to #general immediately before hovering, so the footer deterministically renders 'Active just now' — Desktop Smoke E2E shard 4 has been red on main since de8a274. The sibling message-link assertion already allows the just-now bucket; this aligns the channel one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop Smoke E2E shard 4 has been red on main since
de8a2741c(#6252): the channel-link tooltip expectation only allowsActive Nm ago, but the spec sends a message to #general immediately before hovering, so the footer deterministically rendersActive just now(fails 3/3 retries, both themes — e.g. main run).#6252's sibling message-link assertion already allows the
just nowbucket; this aligns the channel one: