fix(cli): reject empty channel messages - #6493
Open
oletillmann wants to merge 2 commits into
Open
Conversation
Bound non-interactive stdin reads so inherited open pipes cannot block agent sends indefinitely. Reject empty message envelopes at CLI, SDK, and desktop builder boundaries while preserving media-only messages. Co-authored-by: oletillmann <ole@tillmann.com> Signed-off-by: oletillmann <ole@tillmann.com>
Limit the guard to initial stdin inactivity. Once the first byte arrives, allow the producer to take as long as needed to finish, and cover both delayed producers and permanently idle pipes. Co-authored-by: oletillmann <ole@tillmann.com> Signed-off-by: oletillmann <ole@tillmann.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz messages send --content -reads from completely idle non-terminal stdin so an inherited open pipe cannot block indefinitelyWhy
An agent process can inherit an open stdin descriptor and invoke
--content -without attaching a producer. The CLI currently waits forever for the first byte. If the descriptor is eventually closed, an empty message can continue to the signer and relay.This change adds two independent protections:
Tests
cargo test -p buzz-clicargo test -p buzz-sdkcargo clippy -p buzz-sdk -p buzz-cli --all-targets -- -D warningsjust desktop-tauri-testjust ci