perf: use pzstd for snapshot compression#295
Merged
joshfriend merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
7268734 to
b0d5b85
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7268734c18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b0d5b85 to
cb32d76
Compare
alecthomas
reviewed
May 5, 2026
| } | ||
| if config.SnapshotInterval > 0 { | ||
| for _, bin := range []string{"tar", "zstd"} { | ||
| for _, bin := range []string{"tar", "zstd", "pzstd"} { |
Contributor
Author
There was a problem hiding this comment.
they get installed together so no we don't really need to check for both
alecthomas
approved these changes
May 5, 2026
Switch from zstd to pzstd for snapshot archival. pzstd produces multiple independent zstd frames that clients can decompress in parallel. The output is a valid zstd stream readable by any standard zstd decoder.
cb32d76 to
f7ba62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch snapshot compression from
zstdtopzstd, which produces multi-frame output that clients can decompress in parallel. The output is still a valid zstd stream so no client changes are needed.