Skip to content

perf: use pzstd for snapshot compression#295

Merged
joshfriend merged 1 commit intomainfrom
jfriend/pzstd-snapshot-support
May 5, 2026
Merged

perf: use pzstd for snapshot compression#295
joshfriend merged 1 commit intomainfrom
jfriend/pzstd-snapshot-support

Conversation

@joshfriend
Copy link
Copy Markdown
Contributor

@joshfriend joshfriend commented May 5, 2026

Switch snapshot compression from zstd to pzstd, which produces multi-frame output that clients can decompress in parallel. The output is still a valid zstd stream so no client changes are needed.

@joshfriend joshfriend requested a review from a team as a code owner May 5, 2026 23:38
@joshfriend joshfriend requested review from alecthomas and removed request for a team May 5, 2026 23:38
@joshfriend joshfriend force-pushed the jfriend/pzstd-snapshot-support branch from 7268734 to b0d5b85 Compare May 5, 2026 23:39
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7268734c18

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread client/archive.go
@joshfriend joshfriend force-pushed the jfriend/pzstd-snapshot-support branch from b0d5b85 to cb32d76 Compare May 5, 2026 23:48
Comment thread internal/strategy/git/git.go Outdated
}
if config.SnapshotInterval > 0 {
for _, bin := range []string{"tar", "zstd"} {
for _, bin := range []string{"tar", "zstd", "pzstd"} {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need zstd?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they get installed together so no we don't really need to check for both

Switch from zstd to pzstd for snapshot archival. pzstd produces multiple
independent zstd frames that clients can decompress in parallel. The output
is a valid zstd stream readable by any standard zstd decoder.
@joshfriend joshfriend force-pushed the jfriend/pzstd-snapshot-support branch from cb32d76 to f7ba62e Compare May 5, 2026 23:54
@joshfriend joshfriend enabled auto-merge (squash) May 5, 2026 23:55
@joshfriend joshfriend merged commit 5ca72e1 into main May 5, 2026
10 of 11 checks passed
@joshfriend joshfriend deleted the jfriend/pzstd-snapshot-support branch May 5, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants