Fix ActionCable auth fallback + unblock deploy (diff-lcs)#103
Merged
HamptonMakes merged 3 commits intomainfrom May 4, 2026
Merged
Fix ActionCable auth fallback + unblock deploy (diff-lcs)#103HamptonMakes merged 3 commits intomainfrom
HamptonMakes merged 3 commits intomainfrom
Conversation
…pendency to unblock deploy Use shared CoPlan::Authentication for both HTTP and ActionCable contexts, falling back when connection.current_user is absent. This fixes websocket auth failures in hosts without ApplicationCable::Connection. Also add missing diff-lcs dependency required by diff_to_operations to fix deploy error.
HamptonMakes
commented
May 4, 2026
…iption Reject unauthenticated websocket subscriptions early instead of relying on implicit policy checks. Simplifies lifecycle methods and aligns with reviewer feedback.
HamptonMakes
commented
May 4, 2026
Route channel subscription auth through the memoized current_user method instead of reading @current_user directly. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Changes
Verification
Risk
Follow-ups