Rename ListRecords resolver class to IndexedTypeRootFieldsResolver#1166
Merged
myronmarston merged 2 commits intoblock:mainfrom May 5, 2026
Merged
Conversation
rossroberts-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
requested changes
May 5, 2026
The resolver handles both list and aggregation root fields for indexed types, so the new name reflects its actual responsibility. The `:list_records` resolver symbol is preserved to avoid a breaking change to schema artifacts. Generated with Claude Code
Matches the recent class rename (ListRecords -> IndexedTypeRootFieldsResolver) and aligns with the existing naming convention where the registered symbol is the snake_case form of the class name, minus the Resolver suffix (e.g. GetRecordFieldValue -> :get_record_field_value, NestedRelationships -> :nested_relationships). Runtime metadata artifacts regenerate with the new symbol; per the versioning policy, any schema-artifact regeneration is expected on upgrade. Generated with Claude Code
rossroberts-toast
force-pushed
the
OLAP-582_namespaced_queries
branch
from
91e8617 to
8ad9175
Compare
myronmarston
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PR's to to implement the feature detailed in this feature request: #1130
Summary