Add end-to-end acceptance tests for index inheritance#1167
Merged
myronmarston merged 2 commits intoblock:mainfrom May 6, 2026
Merged
Conversation
Updates the NamedInventor interface to use a shared index (with Person and Company inheriting it), adds acceptance tests covering __typename filtering at multiple levels of an abstract type hierarchy, and updates schema artifacts, settings, and test factories accordingly. Generated with Claude Code
marcdaniels-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
approved these changes
May 5, 2026
Co-authored-by: Myron Marston <myron.marston@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This focuses on just the acceptance test for index inheritance and was pulled from the larger PR #1150.
Updates the
NamedInventorinterface to use a shared index (withPersonandCompanyinheriting it), adds acceptance tests covering__typenamefiltering at multiple levels of an abstract type hierarchy, and updates schema artifacts, settings, and test factories accordingly.My goal with changing the
NamedInventortree to use index inheritance is now captured in the acceptance test named "supports querying a type that is both indexed (via interface inheritance) and embedded as a field on another type". We have that in record_preparer_spec.rb ("injects or omits__typenamedepending on whether the record's context requires it") but I thought it would be good to also cover this in the acceptance test.