fix(desktop): prevent-sleep spawn convention + expiry badge#487
Merged
wesbillman merged 1 commit intomainfrom May 5, 2026
Merged
fix(desktop): prevent-sleep spawn convention + expiry badge#487wesbillman merged 1 commit intomainfrom
wesbillman merged 1 commit intomainfrom
Conversation
…ter expiry Two fixes from Codex adversarial review of #484: 1. Replace tokio::spawn with tauri::async_runtime::spawn for the 4-hour cap timer. Follows the codebase convention for spawning from non-async contexts (see huddle/models.rs:381 rationale). 2. Include !expired in the active derivation so the status badge shows "Inactive" after the 4-hour cap fires, matching the actual backend state where the IOKit assertion has been released. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #484, addressing two findings from the Codex adversarial review:
tauri::async_runtime::spawninstead oftokio::spawnfor the 4-hour cap timer. Follows the codebase convention for spawning from non-async contexts (seehuddle/models.rs:381rationale). Stores theJoinHandledirectly instead of extracting anAbortHandle.activederivation now includes&& !expired, so the status badge correctly shows "Inactive" after the cap fires and the IOKit assertion is released.Test plan
cargo checkpassespnpm typecheckpasses🤖 Generated with Claude Code