Merged
Conversation
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
roborivers
approved these changes
Mar 3, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
disttxn
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
roborivers
approved these changes
Mar 4, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate
sc_resume_logicalsc_generated
queuedb_rollover
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
longreq_stats
reco-ddlk-sql
chands10
commented
Mar 4, 2026
| { | ||
| read_available_comdb2db_configs(NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); | ||
| char *dbname = hndl->dbname; | ||
| strcpy(c->db.name, dbname); |
Contributor
Author
There was a problem hiding this comment.
Need to set dbname for addl cfg to be parsed
Contributor
Author
|
cdb2test Mar 3 18:30:49 2026 success addl_cfg_fix.R20260303.9 |
riverszhang89
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbname needs to be defined when reading config in get_connection for dbinfo optimization
Pass in hndl and metadb info since bb does too