Merged
Conversation
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
roborivers
approved these changes
Mar 4, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
truncatesc_offline_generated
Contributor
|
Do not need CDB2BUF_DELAY_MALLOC - delete all code under it |
Contributor
|
|
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
Contributor
Author
|
Like this? |
roborivers
approved these changes
Mar 4, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_timepart [core dumped]
consumer_non_atomic_default_consumer_generated
remsql_locks_rte_connect_generated
remsql_locks
sc_downgrade
truncatesc_offline_generated
akshatsikarwar
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bbcdb2api has this undefined. Do we need to do that?
bb also has #undef CDB2BUF_UNGETC and #undef CDB2BUF_RWFUNCS