Repository navigation
build: type-check docs with tsrs and keep a tsc fallback - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #74. This finishes the tsrs migration to match the org-wide plan used in sfx#75.
checkis nownext typegen && tsrs --noEmit, and it runs inprebuildbeforenext build.next.config.mjssetstypescript.ignoreBuildErrors: true, so Next skips its slowertscpass ("Skipping validation of types" in the build log). tsrs is pinned to exactly0.18.0-ts7.1.0-dev.20260929.typescriptstays a devDependency in both the chart package and the docs app, and Next still needs it too. The new fallback scripts aretypecheck:tsc(root),typecheck/typecheck:tsc/build:ts:tsc(chart) andcheck:tsc(docs).Docs type check (box, 8 vCPU, 7 interleaved cold runs,
.tsbuildinforemoved each run)That's about 12x faster than tsc 6.
Gates
.tsxfile with 5 errors: wrong assignment, a misspelled prop, a non-ReactNode child, a bad argument and a missing required prop.build:ts(tsrs) andbuild:ts:tscemit identical.jsand.d.tsfiles. Only the.mapmappings differ, which is the TS 6 to TS 7 source-map change covered in build: compile @bloxwap/chart with tsrs instead of tsc #74.npm run typecheck,npm run typecheck:tsc,npm run docs:build(includingcheck-export),npm run lintandnpm run coverage, which stays at 100% on all 139 rows.