Repository navigation
fix(deps): resolve OSV-reported advisories in the lockfile - #165
Merged
Merged
Conversation
Pin patched releases of the docs app's vulnerable transitive dependencies through root package.json overrides (all published more than three days ago, so bunfig.toml's minimumReleaseAge still holds): - katex 0.16.47 -> 0.18.11 (GHSA-238p-pmpm-9mq7) - sharp 0.35.4 -> 0.35.5 (GHSA-wq5f-xc86-pv6w) - smol-toml 1.8.0 -> 1.9.0 (GHSA-r4xh-jqrq-34v2) - source-map-js 1.2.1 -> 1.2.2 (GHSA-68fv-2mgg-jv7q) braces has no patched release for GHSA-vfj7-8cjw-p6xm, so add an expiring, single-advisory ignore in osv-scanner.toml and pass it to the Security workflow explicitly. braces is reachable only through markdownlint-cli2, which #163 removes. Also apply the Biome formatting that apps/docs/app/layout.tsx was missing on main, so the format check passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled Security workflow has been red on
mainsince 2026-10-05: OSV-Scanner reports five advisories inbun.lock, all in the docs app's transitive dependencies. This PR clears all five.overridesoverridesoverridesoverridesosv-scanner.toml, expires 2026-12-31minimumReleaseAge = 259200inbunfig.tomlstays as it is.<= 3.0.3is affected, and 3.0.3 is the latest). An override can't fix it, soosv-scanner.tomlignores that one advisory ID until a set date, with a written reason. The Security workflow now passes the config with--config=osv-scanner.toml.apps/docs/app/layout.tsxgets the Biome formatting thatmain(68cb6d2) was missing. Without it,bun run check:formatfails on every PR.Relation to #163
#163 (
fix/docs-drop-markdownlint-cli2) removes markdownlint-cli2, which also takes braces, smol-toml and katex out of the lockfile. Its quality and perf checks are still failing, so this PR getsmaingreen without waiting for it. Once #163 lands, the braces entry inosv-scanner.tomland thekatexandsmol-tomloverrides will no longer match anything and can be deleted. Thesharpandsource-map-jsoverrides are still needed after that.Test plan
osv-scannerv2.3.8 (the version the workflow pins) with the workflow's arguments: 5 findings before this change, "No issues found" afterbun run check(format, lint, docs content incl. markdownlint, types, ts7, jsdoc, exports, imports)bun run test:offline: 1974 pass, 0 failbun run buildcd apps/docs && bun run build && bun run check && bun run test🤖 Generated with Claude Code