feat(agents): adopt customize.toml pattern and agent roster#22
Merged
feat(agents): adopt customize.toml pattern and agent roster#22
Conversation
Mirrors bmm's remove-skill-manifests end-state:
- Per-agent customize.toml encodes persona, menu, and activation hooks
(canonical [agent] block: role, identity, communication_style,
principles, persistent_facts, prepend/append steps, [[agent.menu]]).
- SKILL.md activation rewritten to resolve the agent block via
{project-root}/_bmad/scripts/resolve_customization.py, load
persistent_facts, greet with icon, and dispatch the menu.
- Agent roster added to module.yaml with team field so external skills
(party-mode, retrospective, help catalog) can route, display, and
embody agents without reaching into each skill folder.
- bmad-skill-manifest.yaml removed — superseded by customize.toml
metadata and the module.yaml roster.
Persona wording polished across the five agents (role/identity/
communication_style/principles) following the bmm convention.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 37 minutes and 47 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (48)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Augment PR SummarySummary: This PR updates the Game Dev Studio (GDS) agents to follow BMAD’s newer Changes:
Technical Notes: Agent activation now depends on resolving 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| ### Step 4: Load Persistent Facts | ||
|
|
||
| Treat every entry in `{agent.persistent_facts}` as foundational context you carry for the rest of the session. Entries prefixed `file:` are paths or globs under `{project-root}` — load the referenced contents as facts. All other entries are facts verbatim. |
There was a problem hiding this comment.
Step 4 says file: entries are "paths or globs under {project-root}", but this agent’s default {agent.persistent_facts} includes file:{skill-root}/documentation-standards.md (see customize.toml). Consider widening the wording to allow {skill-root}/other placeholders so the activation instructions don’t contradict the default config (and keep it consistent across the other agents’ SKILL.md files too).
Severity: medium
Other Locations
src/agents/gds-agent-game-dev/SKILL.md:47src/agents/gds-agent-game-architect/SKILL.md:45src/agents/gds-agent-game-designer/SKILL.md:45src/agents/gds-agent-game-solo-dev/SKILL.md:45
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Bmm-style persona optimization — LLMs carry rich priors on named practitioners, so naming them activates those priors and makes agents sharper than generic "X years of experience" framing. Luminary pairings applied to each GDS agent's identity (customize.toml) and essence description (module.yaml): - Cloud Dragonborn (Architect): John Carmack × Tim Sweeney - Samus Shepard (Designer): Shigeru Miyamoto × Sid Meier - Paige (Tech Writer): Julia Evans × Edward Tufte (already applied in customize.toml — now echoed in module.yaml description) - Indie (Solo Dev): Eric Barone × Edmund McMillen - Link Freeman (Game Developer): Casey Muratori × Naoki Yoshida Communication style and principles unchanged — persona priors belong in identity, voice/cadence belongs in communication_style.
6 tasks
bmadcode
added a commit
that referenced
this pull request
Apr 21, 2026
* feat(workflows): adopt customize.toml pattern for workflow skills Merge redirect-only SKILL.md with workflow.md content into a single SKILL.md per workflow skill, add Conventions + On Activation (resolve customization, prepend/append steps, persistent_facts, config load, greet), and wire workflow.on_complete into each workflow's terminal step. External-style workflows (steps-c/, steps-v/, steps-e/, etc.) get the on_complete resolver appended to the final step file; inline workflows get an <action> inside the final <step> block. gds-sprint-status has three terminal branches (main flow step 5, data mode step 20, validate mode step 30) — on_complete wired at each. gds-document-project dispatches into instructions.md + deep-dive-instructions.md + full-scan-instructions.md; on_complete wired at all three terminal points so the hook fires regardless of execution path. Applies the same customization surface shipped for the GDS agent skills in #22. * fix(workflows): address PR review comments - gds-e2e-scaffold, gds-document-project: fix `{skill_root}` typo (underscore) to `{skill-root}` (dash) in `installed_path` so downstream references like `{installed_path}/checklist.md` resolve correctly against the convention declared above. - deep-dive-instructions.md: move the workflow.on_complete resolver from the end of Step 13a (area-selection confirmation loop) to Step 13g (Finish) so the hook only fires when the user actually exits the workflow, not during mid-workflow navigation. * docs(changelog): record v0.4.0 — customize.toml pattern rollout * docs(changelog): correct v0.4.0 release date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors bmm's canonical agent customization end-state (as on the
remove-skill-manifestsbranch of BMAD-METHOD) across the five GDS agents.[agent]block (role, identity, communication_style, principles, persistent_facts, activation hooks,[[agent.menu]]tables). Persona wording polished following the bmm convention — "channels X's Y" identity, simile-based communication style, tightened principles. Link Freeman's consolidated Dev/QA/Scrum Master role preserved.{project-root}/_bmad/scripts/resolve_customization.py, execute prepend steps, adopt persona, load persistent_facts, load config, greet with{agent.icon}, execute append steps, dispatch-or-present the menu. Link Freeman's skill-specific notes (gametest knowledge index, E2E-first load, Unity/Unreal/Godot doc cross-check) preserved at the end of SKILL.md.agents:roster (code / name / title / icon / team / description essence) so external skills like party-mode, retrospective, and the help catalog can route and embody agents without reaching into each skill folder. GDS agents are on thegame-devteam.Dependency
Depends on BMAD-METHOD's
remove-skill-manifestsPR landing: SKILL.md references{project-root}/_bmad/scripts/resolve_customization.py, which is installed by bmm's installer once that PR merges.Test plan
remove-skill-manifestsbranch: each GDS agent activates, resolves its customize.toml, greets with icon, and presents its menu_bmad/custom/gds-agent-game-dev.tomlwith a partial override and confirm scalar/array merge rules holdagents:roster and shows GDS agents on thegame-devteambmad-skill-manifest.yamlreferences in the codebase