Skip to content

Make release validation portable on Windows #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bnjdpn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make release validation portable on Windows #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230d668
Preserve LF release inputs on Windows checkouts
Sep 5, 2026
2a1350b
Keep MSVC developer command quoting intact in tests
Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Release validation parses workflow jobs and verifies canonical patch bytes.
# Keep these inputs identical when Windows checks out with core.autocrlf=true.
.github/workflows/*.yml text eol=lf
patches/*.patch text eol=lf
7 changes: 6 additions & 1 deletion scripts/mod-ollama-chat-patch.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,12 @@ function resolveMsvcEnvironment() {
"/c",
`call "${developerCommand}" -no_logo -arch=x64 -host_arch=x64 >nul && set`,
],
{ encoding: "utf8", stdio: ["ignore", "pipe", "pipe"] },
{
encoding: "utf8",
stdio: ["ignore", "pipe", "pipe"],
// This argument already uses cmd.exe quoting, not Windows argv escaping.
windowsVerbatimArguments: true,
},
);
return mergeWindowsEnvironment(process.env, output);
}
Expand Down
Loading