Fix Number.prototype.toExponential() rounding (closes #4169)#4998
Closed
xcb3d wants to merge 1 commit intoboa-dev:mainfrom
Closed
Fix Number.prototype.toExponential() rounding (closes #4169)#4998xcb3d wants to merge 1 commit intoboa-dev:mainfrom
xcb3d wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Fixed tests (1):Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
===========================================
+ Coverage 47.24% 58.38% +11.14%
===========================================
Files 476 559 +83
Lines 46892 61435 +14543
===========================================
+ Hits 22154 35871 +13717
- Misses 24738 25564 +826 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The issue specifically states avoiding hacks using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #4169.
It changes the following:
format!("{n:.prec$e}")inf64_to_exponential_with_precisionwhich uses banker's rounding (round-half-to-even) with a manual implementation that uses round-half-away-from-zero to match ECMAScript semanticsformat!("{n:.100e}"), then rounds the digit string correctly before formatting the exponential output(25).toExponential(0)returning"2e+1"instead of"3e+1"and(12345).toExponential(3)returning"1.234e+4"instead of"1.235e+4"return-values.jsnow passes in both normal and strict mode