Skip to content

[WIP] Implement Temporal.ZonedDateTime.prototype.toLocaleString#5199

Draft
Vellumic wants to merge 6 commits intoboa-dev:mainfrom
Vellumic:feat/temporal-zoneddatetime-tolocalestring
Draft

[WIP] Implement Temporal.ZonedDateTime.prototype.toLocaleString#5199
Vellumic wants to merge 6 commits intoboa-dev:mainfrom
Vellumic:feat/temporal-zoneddatetime-tolocalestring

Conversation

@Vellumic
Copy link
Contributor

@Vellumic Vellumic commented Mar 21, 2026 •
edited
Loading

This Draft Pull Request fixes/closes #5082

What's done so far:

  • Added initial implementation of toLocaleString()
  • Added helper for accessing calendar related info in DateTimeFormat
  • Delete some code from format_date_time_locale() which broke standard behavior

Next steps:

  • Expand format_date_time_locale() to make it work with Temporal objects
  • Fix the cargo-make integration issue

@github-actions github-actions bot added C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation Waiting On Review Waiting on reviews from the maintainers labels Mar 21, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 21, 2026
@github-actions
Copy link

github-actions bot commented Mar 21, 2026 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,545 50,547 +2
Ignored 1,426 1,426 0
Failed 992 990 -2
Panics 2 2 0
Conformance 95.43% 95.44% +0.00%
Fixed tests (2): 
test/intl402/Temporal/ZonedDateTime/prototype/toLocaleString/dateStyle.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/toLocaleString/time-zone-canonicalized.js (previously Failed)

Tested main commit: 817b6eaade662a49434c5d295667068a4875b378
Tested PR commit: 2791620771951b5763006ff2b880098782673bae
Compare commits: 817b6ea...2791620

@github-actions github-actions bot added C-Dependencies Pull requests that update a dependency file C-Tests Issues and PRs related to the tests. C-Actions Pull requests that update Github Actions code labels Mar 22, 2026
@Vellumic Vellumic force-pushed the feat/temporal-zoneddatetime-tolocalestring branch from aae059c to 2791620 Compare March 22, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams jasonwilliams will be requested when the pull request is marked ready for review jasonwilliams is a code owner

@jedel1043 jedel1043 Awaiting requested review from jedel1043 jedel1043 will be requested when the pull request is marked ready for review jedel1043 is a code owner

@nekevss nekevss Awaiting requested review from nekevss nekevss will be requested when the pull request is marked ready for review nekevss is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

C-Actions Pull requests that update Github Actions code C-Builtins PRs and Issues related to builtins/intrinsics C-Dependencies Pull requests that update a dependency file C-Intl Changes related to the `Intl` implementation C-Tests Issues and PRs related to the tests. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

Implement Temporal.ZonedDateTime.prototype.toLocaleString

1 participant

@Vellumic