Implement Iterator.prototype.includes proposal#5227
Open
nekevss wants to merge 7 commits intoboa-dev:mainfrom
Open
Implement Iterator.prototype.includes proposal#5227nekevss wants to merge 7 commits intoboa-dev:mainfrom
Iterator.prototype.includes proposal#5227nekevss wants to merge 7 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5227 +/- ##
===========================================
+ Coverage 47.24% 59.73% +12.48%
===========================================
Files 476 589 +113
Lines 46892 63431 +16539
===========================================
+ Hits 22154 37889 +15735
- Misses 24738 25542 +804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new Stage 2.7 Iterator includes proposal and adds some tests for it as well.
It's worth noting that the current tests don't take advantage of generator functions because our iterator helpers don't appear to work correctly with them, which we should probably look into. In the meantime, an arrow function returning an iterator was used.
I left the clamping of the skippedElements value to the range of
i64, which I believe should be sufficient since it is beyond the MAX_SAFE_INTEGER.Also worth noting, there's not test262 tests yet AFAIK, so no unflagging is needed currently.
CC: @michaelficarra for the visibility since we were talking about this just the other day