Skip to content

fix(vm/opcode/define,set,call): convert panics to EngineError::Panic using js_expect#5228

Open
KaustubhOG wants to merge 1 commit intoboa-dev:mainfrom
KaustubhOG:convert-vm-opcode-panics
Open

fix(vm/opcode/define,set,call): convert panics to EngineError::Panic using js_expect#5228
KaustubhOG wants to merge 1 commit intoboa-dev:mainfrom
KaustubhOG:convert-vm-opcode-panics

Conversation

@KaustubhOG
Copy link
Contributor

Part of #3241.
Converts all convertible .expect() panics to .js_expect()? in:

  • opcode/define/class/getter.rs(14)
  • opcode/define/class/method.rs (14)
  • opcode/define/class/setter.rs (14)
  • opcode/set/name.rs (1)
  • opcode/set/private.rs (2)
  • opcode/call/mod.rs (6)

Skipped with rationale:

set/private.rs SetPrivateMethod/SetPrivateSetter/SetPrivateGetter — return () instead of JsResult<()>
call/mod.rs remaining .expect() calls spec-guaranteed invariants (ECMAScript ! notation) maybee genuine unreachable invariants inside async context.

@KaustubhOG KaustubhOG requested a review from a team as a code owner March 22, 2026 18:41
@github-actions github-actions bot added C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers labels Mar 22, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 22, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,545 50,545 0
Ignored 1,426 1,426 0
Failed 992 992 0
Panics 2 2 0
Conformance 95.43% 95.43% 0.00%

Tested main commit: 0592ecc32629c18d43dc136b6675ef980f37a061
Tested PR commit: ea672a0297f43a0326c28d714cf8e10408fde309
Compare commits: 0592ecc...ea672a0

@codecov
Copy link

codecov bot commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.76%. Comparing base (6ddc2b4) to head (ea672a0).
⚠️ Report is 915 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/vm/opcode/define/class/setter.rs 16.66% 5 Missing ⚠️
core/engine/src/vm/opcode/define/class/getter.rs 33.33% 4 Missing ⚠️
core/engine/src/vm/opcode/define/class/method.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5228       +/-   ##
===========================================
+ Coverage   47.24%   59.76%   +12.51%     
===========================================
  Files         476      582      +106     
  Lines       46892    63454    +16562     
===========================================
+ Hits        22154    37922    +15768     
- Misses      24738    25532      +794     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-VM Issues and PRs related to the Boa Virtual Machine. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant